Bugfix: ensure consistency of m_failed_blocks after reconsiderblock #13199

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2018-05-fix-reconsider-block changing 1 files +1 −0

sdaftuar commented at 2:38 PM on May 9, 2018: member

This was introduced in 015a5258adffb0cf394f387a95ac9c8afc34cfc3 and could cause a node to crash (due to assertion failure) when using the reconsiderblock rpc.
sdaftuar commented at 2:38 PM on May 9, 2018: member

I think this should be marked for backport.
fanquake added the label Validation on May 9, 2018
fanquake added the label Needs backport on May 9, 2018
Bugfix: ensure consistency of m_failed_blocks after reconsiderblock 11fa6bb66e
sdaftuar force-pushed on May 9, 2018
MarcoFalke added this to the milestone 0.16.1 on May 9, 2018
laanwj commented at 4:07 PM on May 10, 2018: member

utACK 11fa6bb66e8c1562305d034903a0dc6aee6eea20
TheBlueMatt commented at 4:38 PM on May 12, 2018: member

utACK 11fa6bb66e8c1562305d034903a0dc6aee6eea20
sipa commented at 6:23 PM on May 12, 2018: member

utACK 11fa6bb66e8c1562305d034903a0dc6aee6eea20
sipa merged this on May 12, 2018
sipa closed this on May 12, 2018
sipa referenced this in commit 418ae49ee1 on May 12, 2018
fanquake referenced this in commit b99c75b480 on May 17, 2018
fanquake removed the label Needs backport on May 17, 2018
fanquake added the label Needs backport on May 17, 2018
fanquake added this to the "For backport" column in a project

MarcoFalke referenced this in commit 0860130bbf on May 24, 2018
MarcoFalke referenced this in commit c71e535aec on May 24, 2018
fanquake removed the label Needs backport on May 28, 2018
fanquake commented at 9:37 AM on May 28, 2018: member

Backported in #13317.
fanquake removed this from the "For backport" column in a project

Contributors

Labels

Milestone
0.16.1