No description provided.
bench: Add block assemble benchmark #13219
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1805-benchBlockAssemble changing 2 files +116 −0-
MarcoFalke commented at 8:04 PM on May 11, 2018: member
- MarcoFalke force-pushed on May 11, 2018
- MarcoFalke force-pushed on May 11, 2018
- fanquake added the label Tests on May 12, 2018
- MarcoFalke force-pushed on May 12, 2018
- MarcoFalke force-pushed on May 12, 2018
- MarcoFalke force-pushed on May 12, 2018
-
sipa commented at 7:31 PM on May 12, 2018: member
Concept ACK
-
practicalswift commented at 8:38 PM on May 12, 2018: contributor
Very nice!
Concept ACK
-
MarcoFalke commented at 3:44 PM on May 13, 2018: member
Can be tested with e.g. #13011 applied
./src/bench/bench_bitcoin --filter=AssembleBlock -
TheBlueMatt commented at 3:54 PM on May 13, 2018: member
Might be an interesting benchmark to literally dump mempool (+utxo set subset needed to validate them) from some snapshot in time where we have a nontrivial one into a blob and use that to benchmark against. Either that or in some way more realistic mempool makeup then just 100 homogeneous transactions.
On May 11, 2018 8:04:13 PM UTC, MarcoFalke notifications@github.com wrote:
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
- bench: Add block assemble benchmark
-- File Changes --
M src/Makefile.bench.include (1) A src/bench/block_assemble.cpp (115)
-- Patch Links --
https://github.com/bitcoin/bitcoin/pull/13219.patch https://github.com/bitcoin/bitcoin/pull/13219.diff
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/13219
- MarcoFalke force-pushed on May 13, 2018
- MarcoFalke force-pushed on May 13, 2018
-
bench: Add block assemble benchmark fa0fc1bc7e
- MarcoFalke force-pushed on May 13, 2018
-
promag commented at 10:47 PM on May 13, 2018: member
Concept ACK.
-
conscott commented at 7:28 AM on May 14, 2018: contributor
Tested ACK fa0fc1bc7edc7f1dd419db6776dcf89749cc1a00
-
jamesob commented at 6:50 PM on May 17, 2018: member
utACK https://github.com/bitcoin/bitcoin/pull/13219/commits/fa0fc1bc7edc7f1dd419db6776dcf89749cc1a00
Code looks good. We need more benches like this.
-
laanwj commented at 4:49 PM on June 24, 2018: member
utACK fa0fc1bc7edc7f1dd419db6776dcf89749cc1a00
- laanwj merged this on Jun 24, 2018
- laanwj closed this on Jun 24, 2018
- laanwj referenced this in commit 08516e0e65 on Jun 24, 2018
- laanwj referenced this in commit cec84c2f1a on Jun 24, 2018
- laanwj referenced this in commit b1dc39df6e on Jun 24, 2018
- stamhe referenced this in commit 1baddee896 on Jun 27, 2018
- Longyan-Wu referenced this in commit de1fb95c4a on Jul 1, 2018
- marcinja referenced this in commit bfccfe0196 on Jul 10, 2018
- MarcoFalke deleted the branch on Jul 14, 2018
- MarcoFalke referenced this in commit 4d550ffab6 on Jul 30, 2018
- HashUnlimited referenced this in commit f79cc1d259 on Sep 11, 2018
- joemphilips referenced this in commit 1f1186059b on Nov 9, 2018
- deadalnix referenced this in commit 4de1bab17a on Apr 27, 2020
- ftrader referenced this in commit db6ebe7f65 on Aug 17, 2020
- DrahtBot locked this on Sep 8, 2021
