break circular dependency: random/sync -> util -> random/sync #13236

1. 
   ken2812221 commented at 9:36 am on May 15, 2018: contributor

   LogPrintf has acutally been moved to logging.h
2. ken2812221 force-pushed on May 15, 2018
3. ken2812221 force-pushed on May 15, 2018
4. ken2812221 renamed this:
   break circular dependency: random -> util -> random
   break circular dependency: random/sync -> util -> random/sync
   on May 15, 2018
5. 
   practicalswift commented at 11:55 am on May 15, 2018: contributor

   Concept ACK

   Let’s get rid of circular dependencies! 👍

6. 
   MarcoFalke commented at 12:50 pm on May 15, 2018: member

   utACK 695951e3f853cfb1d7b22ddf409d9022993151a4
7. fanquake added the label Refactoring on May 15, 2018
8. 
   promag commented at 1:09 pm on May 15, 2018: member

   utACK 695951e.
9. 
   Empact commented at 8:24 pm on May 15, 2018: member

   utACK 695951e
10. 
    practicalswift commented at 7:06 am on May 16, 2018: contributor

    utACK 695951e3f853cfb1d7b22ddf409d9022993151a4
11. in src/random.cpp:15 in 695951e3f8 outdated

    10@@ -11,15 +11,16 @@
    11 #include <compat.h> // for Windows API
    12 #include <wincrypt.h>
    13 #endif
    14-#include <util.h>             // for LogPrint()
    15-#include <utilstrencodings.h> // for GetTime()
    16+#include <logging.h>          // for LogPrint()
    17+#include <utiltime.h>         // for GetTime()
    

    ---

    ---

    

    Empact commented at 8:59 pm on May 16, 2018:

    nit: unnecessary whitespace
12. in src/random.cpp:22 in 695951e3f8 outdated

    20 #include <chrono>
    21 #include <thread>
    22 
    23 #ifndef WIN32
    24 #include <sys/time.h>
    25+#include <fcntl.h>
    

    ---

    ---

    

    Empact commented at 8:59 pm on May 16, 2018:

    nit: sorting
13. in src/sync.cpp:7 in 695951e3f8 outdated

     3@@ -4,9 +4,10 @@
     4 
     5 #include <sync.h>
     6 
     7+#include <map>
     8 #include <memory>
     9 #include <set>
    10-#include <util.h>
    11+#include <logging.h>
    

    ---

    ---

    

    Empact commented at 9:00 pm on May 16, 2018:

    nit: move the stdlib includes below (as is I believe clang-format will intermix them in the sort)
14. 
    Empact commented at 9:03 pm on May 16, 2018: member

    Just nits I noticed on second look, fine to include with.
15. ken2812221 force-pushed on May 17, 2018
16. ken2812221 force-pushed on May 17, 2018
17. in src/sync.cpp:7 in 80962ffa9f outdated

    3@@ -4,13 +4,15 @@
    4 
    5 #include <sync.h>
    6 
    7-#include <memory>
    8 #include <set>
    

    ---

    ---

    

    Empact commented at 8:05 am on May 17, 2018:

    One more :P

    ---

    

    ken2812221 commented at 8:23 am on May 17, 2018:

    Forgot that, thanks.
18. break circular dependency: random/sync -> util -> random/sync 84f41946b9
19. ken2812221 force-pushed on May 17, 2018
20. 
    Empact commented at 4:17 pm on May 17, 2018: member

    re-utACK 84f4194 - whitespace and include ordering changes only
21. MarcoFalke merged this on May 17, 2018
22. MarcoFalke closed this on May 17, 2018

    ---

23. MarcoFalke referenced this in commit 1b53e4f67c on May 17, 2018
24. ken2812221 deleted the branch on May 17, 2018
25. MarcoFalke referenced this in commit a9b6957383 on May 24, 2018
26. PastaPastaPasta referenced this in commit ee9d3a7021 on Jun 17, 2020
27. PastaPastaPasta referenced this in commit 3d878bdebb on Jun 27, 2020
28. PastaPastaPasta referenced this in commit 788f16788b on Jun 28, 2020
29. PastaPastaPasta referenced this in commit 730a00450a on Jun 29, 2020
30. PastaPastaPasta referenced this in commit 6a71087902 on Jul 1, 2020
31. PastaPastaPasta referenced this in commit 7aad15c389 on Jul 17, 2020
32. PastaPastaPasta referenced this in commit 26ca2ce77d on Jul 18, 2020
33. PastaPastaPasta referenced this in commit 87e9947a2e on Jul 19, 2020
34. random-zebra referenced this in commit 93f43f0f81 on Apr 14, 2021
35. DrahtBot locked this on Sep 8, 2021

Contributors
ken2812221 practicalswift MarcoFalke promag Empact

Labels
Refactoring