GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default #13251

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:rephrase-bech-32 changing 2 files +10 −8
  1. fanquake commented at 2:03 am on May 17, 2018: member
    • “Bech32” isn’t very user-friendly; used “native segwit” as in #11937.
    • You don’t spend from addresses.
    • No reason to block off Bech32 access with legacy address default.

    Rebased from #12208

  2. GUI: Rephrase Bech32 checkbox text/tooltip
    - "Bech32" isn't very user-friendly
    - You don't spend from addresses
    7ab1c6f6a7
  3. GUI: Allow generating Bech32 addresses with a legacy-address default 82dda6bed9
  4. fanquake added the label GUI on May 17, 2018
  5. fanquake added the label Needs backport on May 17, 2018
  6. fanquake added this to the milestone 0.16.1 on May 17, 2018
  7. fanquake commented at 2:03 am on May 17, 2018: member
  8. TheBlueMatt commented at 3:07 pm on May 17, 2018: member
    utACK 82dda6bed971c5638962442b4927845fe5eb6600
  9. MarcoFalke commented at 4:06 pm on May 17, 2018: member
    utACK 82dda6bed971c5638962442b4927845fe5eb6600
  10. MarcoFalke merged this on May 17, 2018
  11. MarcoFalke closed this on May 17, 2018

  12. MarcoFalke referenced this in commit ef0e5cd517 on May 17, 2018
  13. promag commented at 4:11 pm on May 17, 2018: member
    utACK 82dda6b.
  14. GreatSock commented at 4:12 pm on May 17, 2018: contributor

    I think a better tooltip would be “Native segwit addresses (Bech32) reduce your transaction fees later on and offer better protection against typos, but are unsupported by old wallets. When unchecked, an address compatible with older wallets will be created instead.”

    But otherwise utACK https://github.com/bitcoin/bitcoin/pull/13251/commits/82dda6bed971c5638962442b4927845fe5eb6600

  15. jonasschnelli commented at 4:15 pm on May 17, 2018: contributor
    Post Merge utACK 82dda6bed971c5638962442b4927845fe5eb6600
  16. luke-jr commented at 5:59 am on May 18, 2018: member
    Thanks. Sorry I’ve fallen so far behind on rebases. :(
  17. fanquake added this to the "For backport" column in a project

  18. MarcoFalke referenced this in commit ea487f9f90 on May 24, 2018
  19. MarcoFalke referenced this in commit 0eda98d01b on May 24, 2018
  20. fanquake deleted the branch on May 26, 2018
  21. fanquake removed this from the "For backport" column in a project

  22. fanquake removed the label Needs backport on May 28, 2018
  23. fanquake commented at 10:13 am on May 28, 2018: member
    Backported in #13319
  24. HashUnlimited referenced this in commit 85caf24632 on Jun 29, 2018
  25. HashUnlimited referenced this in commit ff4de6e1c6 on Jun 29, 2018
  26. ccebrecos referenced this in commit 11c054993c on Sep 14, 2018
  27. TheArbitrator referenced this in commit 47013b051d on Jun 21, 2021
  28. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me