trivial: Mark overrides as such. #13282

pull domob1812 wants to merge 1 commits into bitcoin:master from domob1812:mark-override changing 2 files +9 −9

domob1812 commented at 4:53 PM on May 19, 2018: contributor

This trivial change adds the override keyword to some methods that override virtual base class / interface methods. This ensures that any future changes to the interface's method signatures which are not correctly mirrored in the subclasses will break at compile time with a clear error message, rather than at runtime.
GreatSock commented at 5:37 PM on May 19, 2018: contributor

ACK https://github.com/bitcoin/bitcoin/pull/13282/commits/bc3e897070ff732937e9e13a1fe23fed03744d5d
sipa commented at 5:44 PM on May 19, 2018: member

You can also include ConsolePrinter and PlotlyPrinter in src/bench/bench.h.
domob1812 commented at 5:52 PM on May 19, 2018: contributor

Indeed, added the printers in a second commit. (I actually ran into the test failure while maintaining Namecoin. But including more of these is of course even better.)
MarcoFalke added the label Refactoring on May 19, 2018
fanquake commented at 5:56 AM on May 20, 2018: member

@domob1812 Can you please squash your commits.

trivial: Mark overrides as such.

This trivial change adds the "override" keyword to some methods of
subclasses meant to override interface methods.  This ensures that any
future change to the interface' method signatures which are not correctly
mirrored in the subclass will break at compile time with a clear error message,
rather than fail at runtime (which is harder to debug).

60ebc7da4c

domob1812 force-pushed on May 20, 2018
domob1812 commented at 7:18 AM on May 20, 2018: contributor

Squashed the commits.
Empact commented at 6:17 AM on May 21, 2018: member

utACK 60ebc7d
promag commented at 3:25 PM on May 21, 2018: member

utACK 60ebc7d.
fanquake commented at 10:00 AM on May 22, 2018: member

utACK 60ebc7d
MarcoFalke merged this on May 22, 2018
MarcoFalke closed this on May 22, 2018
MarcoFalke referenced this in commit 6916024768 on May 22, 2018
domob1812 deleted the branch on May 22, 2018
deadalnix referenced this in commit f0513e9cbe on Mar 4, 2020
UdjinM6 referenced this in commit 9e3b85d0f1 on May 21, 2021
UdjinM6 referenced this in commit 96e4214657 on Jun 5, 2021
UdjinM6 referenced this in commit 464a5e3c77 on Jun 5, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels