gui: fix visual "overflow" of amount input. #13284

pull brandontruggles wants to merge 1 commits into bitcoin:master from brandontruggles:ui_amount_overflow_fix changing 1 files +1 −1
  1. brandontruggles commented at 5:22 AM on May 20, 2018: contributor

    Fixes #13231.

    I was able to reproduce this bug within my own Fedora 27 VM. Following @jonasschnelli's advice, I first tried to change setAlignment(Qt::AlignRight); to setAlignment(Qt::AlignLeft);, however, I realized that this wouldn't fix the underlying overflow problem, as it would only make it easier to see the most significant digits under certain scenarios. The reason for the overflow is that Fedora uses plus and minus buttons on the Qt spin box class, rather than up and down arrows, which is what happens on most other operating systems. These plus and minus buttons take up more width, and therefore provide less space for text.

    The solution I went with was the second suggestion by @jonasschnelli, which was to just increase the maximum width of the amount box. After some experimentation, 240 seemed to be the smallest max width that would allow as many digits as one would want in the amount box without overflow, even with the plus and minus buttons in Fedora.

    Please let me know if there are any issues with this PR and I will work to fix them. Thank you!

  2. Increased max width of amount field to prevent number overflow bug. 5f3cbde9de
  3. fanquake added the label GUI on May 20, 2018
  4. GreatSock commented at 10:29 AM on May 20, 2018: contributor

    utACK

    I think you need to use the "fixes" or "closes" keyword before the referenced issue to make sure it closes on merge.

  5. brandontruggles commented at 3:53 PM on May 20, 2018: contributor

    @GreatSock Done!

  6. brandontruggles renamed this:
    Fix for Issue #13231 - [gui] visual "overflow" of amount input.
    Qt: Fix for Issue #13231 - [gui] visual "overflow" of amount input.
    on May 20, 2018
  7. promag commented at 3:38 PM on May 21, 2018: member

    utACK 5f3cbde.

  8. brandontruggles commented at 9:45 PM on May 23, 2018: contributor

    @marcoagner Tagging you here just so you're aware of the PR. Thanks!

  9. marcoagner commented at 9:15 AM on May 24, 2018: contributor

    ACK 5f3cbde9d.

  10. fanquake commented at 12:12 PM on May 24, 2018: member

    I did a quick test with a Fedora VM with master (6378eef): fedora - unfixed

    and this PR (5f3cbde): fedora - fixed

    Also tested on macOS master (6378eef): macos unfixed

    and this PR (5f3cbde): macos fixed

    where I couldn't reproduce the problem (as per the original issue), and the fix looks fine.

    tACK 5f3cbde

  11. fanquake renamed this:
    Qt: Fix for Issue #13231 - [gui] visual "overflow" of amount input.
    gui: fix visual "overflow" of amount input.
    on May 24, 2018
  12. MarcoFalke commented at 1:45 PM on May 24, 2018: member

    utACK 5f3cbde9de842a8d565b6580c6050310d897065b. Good to have some white space around the amounts!

  13. MarcoFalke assigned jonasschnelli on May 24, 2018
  14. jonasschnelli commented at 1:48 PM on May 24, 2018: contributor

    Build: https://bitcoin.jonasschnelli.ch/build/625

    utACK 5f3cbde9de842a8d565b6580c6050310d897065b. Someone willing to test this on Windows?

  15. laanwj commented at 1:52 PM on May 24, 2018: member

    utACK 5f3cbde9de842a8d565b6580c6050310d897065b

  16. laanwj merged this on May 24, 2018
  17. laanwj closed this on May 24, 2018

  18. laanwj referenced this in commit f8be434133 on May 24, 2018
  19. brandontruggles deleted the branch on May 24, 2018
  20. jasonbcox referenced this in commit 9202436665 on Oct 11, 2019
  21. PastaPastaPasta referenced this in commit de56b61b96 on Jun 17, 2020
  22. PastaPastaPasta referenced this in commit 28bfdef125 on Jun 27, 2020
  23. PastaPastaPasta referenced this in commit b858211051 on Jun 28, 2020
  24. PastaPastaPasta referenced this in commit d2605f8d39 on Jun 29, 2020
  25. PastaPastaPasta referenced this in commit cd1dc46115 on Jul 1, 2020
  26. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me