Report progress in ReplayBlocks while rolling forward #13310

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-05-replayblocks-progress changing 1 files +1 −0

promag commented at 10:55 AM on May 23, 2018: member

Fixes #13303.
Report progress in ReplayBlocks while rolling forward b16ab9af07
promag commented at 11:02 AM on May 23, 2018: member

Should only report each 5% for instance?
Empact commented at 11:31 AM on May 23, 2018: member

CWallet::ScanForWalletTransactions has an implementation that only reports every 1% 100 blocks.
promag commented at 11:38 AM on May 23, 2018: member

@Empact IMO the receiver is the one that should throttle, because he is the one that knows the resolution. Anyway, looks like ScanForWalletTransactions reports progress each 100 blocks, or am I wrong?
Empact commented at 11:54 AM on May 23, 2018: member

Yep you're right on ScanForWalletTransactions.
fanquake added the label GUI on May 23, 2018
fanquake added the label Validation on May 23, 2018
GreatSock commented at 9:13 PM on May 23, 2018: contributor

I think it should report every 1% change. But since changes less than 1% won't be visible, maybe check if the percentage have actually changed before updating. Calling ShowProgress 100 times should be fine right?
promag commented at 9:21 PM on May 23, 2018: member

I don't mind doing something like that...

But since changes less than 1% won't be visible

But how do you know? What if you have a progress bar with, for instance, 200px width? It should report 0.5%.
GreatSock commented at 9:34 PM on May 23, 2018: contributor

Right now ShowProgress seems to take an integer which means 1% changes won't be visible.

But I agree: ShowProgress should instead take a float(maybe even between 0 and 1) and then check if it should update by itself. This would probably be better since it can then choose to display the progress however it wants.
promag commented at 9:39 PM on May 23, 2018: member

Actually I was thinking in something like ShowProgress(int min, int value, int max).
GreatSock commented at 9:48 PM on May 23, 2018: contributor

I would personally prefer giving it a float since I feel like it would be more flexible. But then again, why not do both? We could just overload the function.
jonasschnelli commented at 8:39 AM on May 25, 2018: contributor

What is the best test plan to test this?
DrahtBot closed this on Jul 22, 2018
DrahtBot commented at 11:48 PM on July 22, 2018: member

The last travis run for this pull request was 60 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.
DrahtBot reopened this on Jul 22, 2018
jb55 commented at 6:29 AM on September 6, 2018: member

Anything left to do here?
laanwj commented at 12:07 PM on September 13, 2018: member

utACK b16ab9af07f802cc769c2443df1c637e8e12ab80
laanwj merged this on Sep 13, 2018
laanwj closed this on Sep 13, 2018
laanwj referenced this in commit b9ed2fd026 on Sep 13, 2018
laanwj commented at 12:26 PM on September 13, 2018: member

Anything left to do here?

Not really—I think the most important thing to review here is that divide by zero never happens.
jasonbcox referenced this in commit 763b426f4d on Jul 8, 2020
PastaPastaPasta referenced this in commit e6f1719ee8 on Jun 27, 2021
PastaPastaPasta referenced this in commit dd58650a20 on Jun 28, 2021
PastaPastaPasta referenced this in commit 79ce413991 on Jun 29, 2021
PastaPastaPasta referenced this in commit dbc2e70096 on Jul 1, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13303 GUI: ShowProgress is missing during ReplayBlocks()