Ensure gitian-build.sh uses bash #13320

pull jhfrontz wants to merge 1 commits into bitcoin:master from jhfrontz:patch-1 changing 1 files +1 −0
  1. jhfrontz commented at 7:34 PM on May 25, 2018: contributor

    If the user has some other login shell (e.g., ksh), the bashisms in gitian-build.sh don't work so well. #! /bin/bash fixes this.

  2. Ensure gitian-build.sh uses bash
    If the user has some other login shell (e.g., ksh), the bashisms in gitian-build.sh don't work so well.
    410a4e47d5
  3. ken2812221 commented at 10:04 PM on May 25, 2018: contributor

    utACK 410a4e47

  4. in contrib/gitian-build.sh:1 in 410a4e47d5 
       0 | @@ -1,3 +1,4 @@
   1 | +#! /bin/bash
    Empact commented at 12:18 AM on May 26, 2018:

    nit: the space here is atypical fyi

  5. kristapsk commented at 12:25 AM on May 26, 2018: contributor

    utACK 410a4e47d5b5e2e2e1a46971f248e38af4ba9d2f

  6. fanquake added the label Scripts and tools on May 26, 2018
  7. achow101 commented at 4:33 AM on May 26, 2018: member

    utACK 410a4e47d5b5e2e2e1a46971f248e38af4ba9d2f

  8. laanwj commented at 1:19 PM on May 28, 2018: member

    utACK I think we should mention this in a coding standard, if we had one for shell scripts: if bash-isms are used, explicitly use /bin/bash as interpreter.

  9. fanquake commented at 1:32 PM on May 29, 2018: member

    utACK 410a4e4

  10. laanwj commented at 1:58 PM on May 29, 2018: member

    Merging this with the redundant space removed. 410a4e47d5b5e2e2e1a46971f248e38af4ba9d2f → f44a0ebfff2e11c922bba577d64f115c566131c4

  11. laanwj referenced this in commit e08c130c25 on May 29, 2018
  13. fanquake closed this on May 29, 2018
  14. MarcoFalke locked this on Sep 8, 2021
Contributors
jhfrontzken2812221Empactkristapskachow101laanwjfanquake
Labels
Scripts and tools
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me