Make ReceivedBlockTransactions return void #13412

1. 
   MarcoFalke commented at 3:10 pm on June 7, 2018: member

   Instead of always returning bool{true} and forcing the caller to handle the return code, make it void and remove “a bunch” of dead code at the call sites.
2. MarcoFalke added the label Refactoring on Jun 7, 2018
3. 
   practicalswift commented at 5:08 pm on June 7, 2018: contributor

   utACK fae4c86a38d90b7143a7b24e7752cb77b9a92f35
4. 
   Empact commented at 9:17 pm on June 7, 2018: member

   utACK fae4c86
5. 
   promag commented at 10:11 pm on June 7, 2018: member

   utACK fae4c86.
6. 
   ken2812221 commented at 10:16 pm on June 7, 2018: contributor

   utACK fae4c86
7. MarcoFalke force-pushed on Jun 8, 2018
8. Make ReceivedBlockTransactions return void fafa270328
9. MarcoFalke force-pushed on Jun 8, 2018
10. 
    MarcoFalke commented at 4:29 pm on June 8, 2018: member

    Force pushed to removed one more line of dead code
11. 
    Empact commented at 8:31 pm on June 8, 2018: member

    re-utACK fafa270 update removes unused state arg
12. ken2812221 approved
13. 
    ken2812221 commented at 8:38 pm on June 9, 2018: contributor

    utACK fafa270
14. 
    jamesob commented at 8:33 pm on June 15, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/13412/commits/fafa27032876832ab2ed9bf0e20e2d448f012179
15. 
    laanwj commented at 4:38 pm on June 16, 2018: member

    utACK fafa27032876832ab2ed9bf0e20e2d448f012179
16. laanwj merged this on Jun 18, 2018
17. laanwj closed this on Jun 18, 2018

    ---

18. laanwj referenced this in commit ac3224c8ee on Jun 18, 2018
19. MarcoFalke deleted the branch on Jun 26, 2018
20. 
    practicalswift commented at 9:41 am on July 27, 2018: contributor

    Reviewers of this PR – see the similar PR #13774 which could help from your review :-)
21. jasonbcox referenced this in commit 6399a3a3fb on Jan 3, 2020
22. PastaPastaPasta referenced this in commit bd082627cb on Jul 7, 2020
23. PastaPastaPasta referenced this in commit 02628a2572 on Jul 7, 2020
24. PastaPastaPasta referenced this in commit aaad79d9a2 on Jul 8, 2020
25. jonspock referenced this in commit 2630c5fb58 on Oct 6, 2020
26. jonspock referenced this in commit df08093999 on Oct 10, 2020
27. jonspock referenced this in commit 0254f37727 on Oct 10, 2020
28. jonspock referenced this in commit cadabfe600 on Oct 10, 2020
29. jonspock referenced this in commit bc45cb7b78 on Oct 10, 2020
30. jonspock referenced this in commit 3e3d54cc66 on Oct 10, 2020
31. jonspock referenced this in commit b5448a4cba on Oct 10, 2020
32. jonspock referenced this in commit 21d4127af4 on Oct 10, 2020
33. DrahtBot locked this on Sep 8, 2021

Contributors
MarcoFalke practicalswift Empact promag ken2812221 jamesob laanwj

Labels
Refactoring