Drop ParseHashUV in favor of calling ParseHashStr #13422

pull Empact wants to merge 1 commits into bitcoin:master from Empact:parse-hash-uv changing 3 files +1 −10

Empact commented at 5:54 PM on June 8, 2018: member

The one existing call already validates get_str will pass via checkObject: https://github.com/bitcoin/bitcoin/pull/13422/files#diff-8fe4d6985ee4acf8bfc1ed8db1e83cb5L586

Split from #13420

Drop ParseHashUV in favor of calling ParseHashStr

The one existing call already validates get_str will
pass via checkObject.

abd2678ac1

MarcoFalke commented at 6:18 PM on June 8, 2018: member

utACK abd2678ac1af10f55b8b29507407c9e286e06f09
Empact commented at 12:54 AM on June 9, 2018: member

7 hours without a tag and I'm worried for the health and safety of @fanquake. :P
fanquake added the label Refactoring on Jun 9, 2018
Empact commented at 1:23 AM on June 9, 2018: member

Glad you're still with us! ;)
promag commented at 1:45 PM on June 10, 2018: member

utACK abd2678.
DrahtBot commented at 8:27 PM on June 14, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13399 (rpc: Add submitblockheader by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
sipa commented at 1:02 AM on June 15, 2018: member

utACK abd2678ac1af10f55b8b29507407c9e286e06f09
MarcoFalke merged this on Jun 15, 2018
MarcoFalke closed this on Jun 15, 2018
MarcoFalke referenced this in commit 2b770080a4 on Jun 15, 2018
Empact deleted the branch on Jul 2, 2018
PastaPastaPasta referenced this in commit 1c002dd1b6 on Jul 7, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels