When build fails due to lib missing, indicate which one #13435

pull Empact wants to merge 1 commits into bitcoin:master from Empact:lib-missing changing 1 files +21 −21

Empact commented at 9:47 AM on June 11, 2018: member

A failure of "lib missing" has limited utility.
fanquake added the label Build system on Jun 11, 2018
laanwj requested review from theuni on Jun 11, 2018
laanwj commented at 12:27 PM on June 11, 2018: member

Concept ACK (tagged @theuni for review)

can you paste an example error before and after this change if a lib is missing?
promag commented at 1:33 PM on June 11, 2018: member

Concept ACK, it's a useful detail.

Nit, same format as https://github.com/bitcoin/bitcoin/blob/3f0f39415bd7dfcb246926dbb0b29f98d6f19da5/configure.ac#L1054
practicalswift commented at 6:34 PM on June 11, 2018: contributor

Concept ACK

Nice usability improvement!
When build fails due to lib missing, indicate which one
A failure of "lib missing" has limited utility.
51cd508e2f
Empact force-pushed on Jun 11, 2018
Empact commented at 8:29 PM on June 11, 2018: member

Updated format
practicalswift commented at 8:36 PM on June 11, 2018: contributor

utACK 51cd508e2fb429f7c23a0bbbf4b8687386276105

Empact commented at 11:35 PM on June 11, 2018: member

Before this change:

$ ./configure --enable-glibc-back-compat
checking build system type... x86_64-apple-darwin17.5.0
[...]
checking for __attribute__((visibility))... no
checking for __attribute__((dllexport))... no
checking for __attribute__((dllimport))... no
checking for clock_gettime in -lrt... no
configure: error: lib missing

After this change:

$ make clean
$ ./configure --enable-glibc-back-compat
checking build system type... x86_64-apple-darwin17.5.0
[...]
checking for __attribute__((visibility))... no
checking for __attribute__((dllexport))... no
checking for __attribute__((dllimport))... no
checking for clock_gettime in -lrt... no
configure: error: librt missing

theuni approved
theuni commented at 9:00 PM on June 12, 2018: member

utACK 51cd508e2fb429f7c23a0bbbf4b8687386276105
MarcoFalke commented at 10:36 PM on June 12, 2018: member

utACK 51cd508
ken2812221 approved
ken2812221 commented at 10:59 AM on June 13, 2018: contributor

utACK 51cd508
laanwj merged this on Jun 13, 2018
laanwj closed this on Jun 13, 2018
laanwj referenced this in commit cf7ca60923 on Jun 13, 2018
Empact deleted the branch on Jul 14, 2018
PastaPastaPasta referenced this in commit 8a78e4f152 on Jul 7, 2020
gades referenced this in commit a3f0d0e866 on Jun 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels