#13402 added some lock annotations in comments. This pull removes them and adds clang-readable locking annotations instead.
doc: Rewrite some validation docs as lock annotations #13481
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-docValLockAnnot changing 2 files +26 −26-
MarcoFalke commented at 7:27 PM on June 15, 2018: member
- MarcoFalke added the label Docs on Jun 15, 2018
-
DrahtBot commented at 7:33 PM on June 15, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #13083 (Add compile time checking for cs_main runtime locking assertions by practicalswift)
- #11652 (Add missing locks: validation.cpp + related by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
practicalswift commented at 8:14 PM on June 15, 2018: contributor
utACK 712108e9ec2ce20a5759106a13cadf506a5f9367
Very nice!
- fanquake added the label Validation on Jun 16, 2018
-
qmma70 commented at 6:41 PM on June 16, 2018: contributor
utAck
-
doc: Rewrite some validation doc as lock annotations fa324a8b15
- MarcoFalke force-pushed on Jun 18, 2018
-
MarcoFalke commented at 4:20 PM on June 18, 2018: member
I tagged this with "doc", since the objdump doesn't show any difference for me. (Though, the binaries don't yield the same hash.)
-
promag commented at 9:52 PM on June 23, 2018: member
utACK fa324a8.
-
sipa commented at 12:18 AM on June 27, 2018: member
utACK fa324a8b15a4ef4138685b3427c895ec14faf3af
-
laanwj commented at 7:53 PM on July 9, 2018: member
utACK fa324a8b15a4ef4138685b3427c895ec14faf3af
- laanwj merged this on Jul 9, 2018
- laanwj closed this on Jul 9, 2018
- laanwj referenced this in commit b641f60425 on Jul 9, 2018
- MarcoFalke deleted the branch on Jul 10, 2018
- Mengerian referenced this in commit ba606ae94f on Oct 31, 2019
- PastaPastaPasta referenced this in commit db330eedae on Jul 9, 2020
- PastaPastaPasta referenced this in commit 19484930b9 on Jul 9, 2020
- jonspock referenced this in commit a0671a1a39 on Oct 1, 2020
- jonspock referenced this in commit 69520cfa8e on Oct 1, 2020
- jonspock referenced this in commit b15d1e32d7 on Oct 5, 2020
- jonspock referenced this in commit 6ba3f3a187 on Oct 10, 2020
- MarcoFalke locked this on Sep 8, 2021
