Instead of always returning bool{true} and forcing the caller to handle the return code, make it void and remove "a bunch" of dead code at the call sites.
Make ReceivedBlockTransactions return void #13412
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-refactorReturnCodeValidation changing 1 files +4 −9-
MarcoFalke commented at 3:10 PM on June 7, 2018: member
- MarcoFalke added the label Refactoring on Jun 7, 2018
-
practicalswift commented at 5:08 PM on June 7, 2018: contributor
utACK fae4c86a38d90b7143a7b24e7752cb77b9a92f35
-
Empact commented at 9:17 PM on June 7, 2018: member
utACK fae4c86
-
promag commented at 10:11 PM on June 7, 2018: member
utACK fae4c86.
-
ken2812221 commented at 10:16 PM on June 7, 2018: contributor
utACK fae4c86
- MarcoFalke force-pushed on Jun 8, 2018
-
Make ReceivedBlockTransactions return void fafa270328
- MarcoFalke force-pushed on Jun 8, 2018
-
MarcoFalke commented at 4:29 PM on June 8, 2018: member
Force pushed to removed one more line of dead code
-
Empact commented at 8:31 PM on June 8, 2018: member
re-utACK fafa270 update removes unused
statearg - ken2812221 approved
-
ken2812221 commented at 8:38 PM on June 9, 2018: contributor
utACK fafa270
-
jamesob commented at 8:33 PM on June 15, 2018: member
-
laanwj commented at 4:38 PM on June 16, 2018: member
utACK fafa27032876832ab2ed9bf0e20e2d448f012179
- laanwj merged this on Jun 18, 2018
- laanwj closed this on Jun 18, 2018
- laanwj referenced this in commit ac3224c8ee on Jun 18, 2018
- MarcoFalke deleted the branch on Jun 26, 2018
-
practicalswift commented at 9:41 AM on July 27, 2018: contributor
Reviewers of this PR – see the similar PR #13774 which could help from your review :-)
- jasonbcox referenced this in commit 6399a3a3fb on Jan 3, 2020
- PastaPastaPasta referenced this in commit bd082627cb on Jul 7, 2020
- PastaPastaPasta referenced this in commit 02628a2572 on Jul 7, 2020
- PastaPastaPasta referenced this in commit aaad79d9a2 on Jul 8, 2020
- jonspock referenced this in commit 2630c5fb58 on Oct 6, 2020
- jonspock referenced this in commit df08093999 on Oct 10, 2020
- jonspock referenced this in commit 0254f37727 on Oct 10, 2020
- jonspock referenced this in commit cadabfe600 on Oct 10, 2020
- jonspock referenced this in commit bc45cb7b78 on Oct 10, 2020
- jonspock referenced this in commit 3e3d54cc66 on Oct 10, 2020
- jonspock referenced this in commit b5448a4cba on Oct 10, 2020
- jonspock referenced this in commit 21d4127af4 on Oct 10, 2020
- DrahtBot locked this on Sep 8, 2021
Labels