Scripts and tools: Obsolete #!/bin/bash shebang #13510

#!/bin/bash assumes it is always installed to /bin/ which can cause issues #!/usr/bin/env bash searches the user's PATH to find the bash binary

Details: https://github.com/dylanaraps/pure-bash-bible#obsolete-syntax

I'm open to comments: Should I also fix #!/bin/sh?

utACK 000000035b20402dea3e8168165cd4eefdc97539

utACK 0000000.

Did you bruteforce that hash? What did you use as the nonce?

@luke-jr

git log --format=fuller 0000000 -1
commit 000000035b20402dea3e8168165cd4eefdc97539
Author:     DesWurstes <DesWurstes@users.noreply.github.com>
AuthorDate: Wed Jun 20 12:54:54 2018 +0300
Commit:     DesWurstes <DesWurstes@users.noreply.github.com>
CommitDate: Wed Jun 20 11:12:41 2018 +0300

    Obsolete #!/bin/bash shebang

Timestamp, it is two hours earlier than the actual commit time.

utACK 000000035b20402dea3e8168165cd4eefdc97539

Nice hash!

utACK 0000000

Agree that this is better. BSD ports tend to install bash to /usr/local, for example.

I'm open to comments: Should I also fix #!/bin/sh?

I'd say, no. /bin/sh is by definition the system shell. Use of the system shell has its own issues (like the script having to be compatible with 80's shell dialect, the lowest common denominator of all shells), but the location is not one of them.

utACK https://github.com/bitcoin/bitcoin/commit/000000035b20402dea3e8168165cd4eefdc97539