[wip] depends: native_protobuf 3.6.1 #13513

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends-protobuf-36 changing 2 files +4 −4
  1. fanquake commented at 2:34 AM on June 21, 2018: member

    From 3.6.0 onwards, Protobuf requires C++11. See discussion in https://github.com/google/protobuf/issues/2780. This updates depends to that release, and swaps to the cpp specific download.

    TODO:

    • Do we still need to explicitly pass -std=c++11 to cxxflags in our protobuf package?
    • Needs more testing/depends builds done on platforms other than macOS.

    Protobuf 3.6.1 (C++) release notes:

    • Introduced workaround for Windows issue with std::atomic and std::once_flag initialization.

    Protobuf 3.6.0 (C++) release notes:

    • Starting from this release, we now require C++11. For those we cannot yet upgrade to C++11, we will try to keep the 3.5.x branch updated with critical bug fixes only. If you have any concerns about this, please comment on issue #2780.
    • Moved to C++11 types like std::atomic and std::unique_ptr and away from our old custom-built equivalents.
    • Added support for repeated message fields in lite protos using implicit weak fields. This is an experimental feature that allows the linker to strip out more unused messages than previously was possible.
    • Fixed SourceCodeInfo for interpreted options and extension range options.
    • Fixed always_print_enums_as_ints option for JSON serialization.
    • Added support for ignoring unknown enum values when parsing JSON.
    • Create std::string in Arena memory.
    • Fixed ValidateDateTime to correctly check the day.
    • Fixed bug in ZeroCopyStreamByteSink.
    • Various other cleanups and fixes.
  2. fanquake added the label Build system on Jun 21, 2018
  3. fanquake requested review from theuni on Jun 21, 2018
  4. MarcoFalke commented at 2:57 AM on June 21, 2018: member

    What would be the main advantage of this bump?

  5. fanquake force-pushed on Aug 2, 2018
  6. fanquake renamed this:
    [wip] depends: native_protobuf 3.6.0
    [wip] depends: native_protobuf 3.6.1
    on Aug 2, 2018
  7. DrahtBot commented at 4:23 PM on August 2, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->No more conflicts as of last run.

  8. DrahtBot commented at 4:10 PM on August 6, 2018: member

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  9. DrahtBot added the label Needs rebase on Aug 6, 2018
  10. fanquake force-pushed on Aug 7, 2018
  11. fanquake removed the label Needs rebase on Aug 7, 2018
  12. depends: native_protobuf 3.6.1 07688b4d91
  13. fanquake force-pushed on Aug 17, 2018
  14. fanquake commented at 5:30 AM on October 9, 2018: member

    Closing, going to wrap this up in some more extensive depends work.

  15. fanquake closed this on Oct 9, 2018

  16. fanquake removed review request from theuni on Oct 9, 2018
  17. MarcoFalke referenced this in commit f4e4ea1cee on Oct 26, 2018
  18. fanquake deleted the branch on Jan 22, 2020
  19. Munkybooty referenced this in commit bf4bb4b60b on Jul 21, 2021
  20. Munkybooty referenced this in commit 1c412d10cb on Jul 21, 2021
  21. Munkybooty referenced this in commit 31eb125b9f on Jul 22, 2021
  22. Munkybooty referenced this in commit 03981cebc8 on Jul 22, 2021
  23. Munkybooty referenced this in commit 1e2f6aa8a3 on Jul 23, 2021
  24. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me