No description provided.
doc: correct versions in dependencies.md #13853
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:correct-dependencies changing 1 files +11 −11-
fanquake commented at 2:26 PM on August 2, 2018: member
- fanquake added the label Docs on Aug 2, 2018
-
MarcoFalke commented at 2:33 PM on August 2, 2018: member
utACK ea384681a4c04ecf2904974a71b887b99c43bea7
- MarcoFalke added this to the milestone 0.17.0 on Aug 2, 2018
-
Sjors commented at 2:44 PM on August 2, 2018: member
utACK ea38468
What's the reason
freetype,libevent,libICE,libSM,libX11,libXau, etc. aren't listed? Are they sub-dependencies? -
DrahtBot commented at 2:54 PM on August 2, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #13578 ([depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions by mruddy)
- #13513 ([wip] depends: native_protobuf 3.6.1 by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
laanwj commented at 4:05 PM on August 2, 2018: member
What's the reason freetype, libevent, libICE, libSM, libX11, libXau, etc. aren't listed? Are they sub-dependencies?
libevent is listed, and it should be, as we use the directly for RPC http.
The others are indeed indirect, anecdotally I've been able to run bitcoin-qt on Wayland on Linux without them, and you'll certainly be able to run without them on MacOS/Windows. They're possible dependencies of Qt, not of our code.
-
doc: correct versions in dependencies.md 322d34ef65
- fanquake force-pushed on Aug 3, 2018
-
laanwj commented at 2:02 PM on August 6, 2018: member
On the other hand this lists libjpeg/libpng as well, which aren't directly used by our code either. Though they are required on every OS/WM at least because we ship jpg and png images...
-
laanwj commented at 2:39 PM on August 6, 2018: member
anyhow utACK 322d34ef65d5f1c6b58e7bd3fb3cd008d7983167
- laanwj merged this on Aug 6, 2018
- laanwj closed this on Aug 6, 2018
- laanwj referenced this in commit 317477a246 on Aug 6, 2018
- fanquake deleted the branch on Aug 7, 2018
- DrahtBot locked this on Sep 8, 2021