Drop unused GetType() from CSizeComputer #13558

1. 
   Empact commented at 5:08 am on June 28, 2018: member

   Based on conversation in #13462, it seems the serialization GetType has very narrow use/effect. In every case except for CAddress, which specifically relates to a network peer’s address, not a wallet address etc., the serialized representation of an object is irrespective of its destination / type.

   This removes the unused GetType method from CSizeComputer as a step to further narrowing that use.

2. fanquake added the label Refactoring on Jun 28, 2018
3. 
   DrahtBot commented at 9:27 am on June 28, 2018: member

   • #14191 ([RPC] decodeblock by instagibbs)
   • #13359 (Directly operate with CMutableTransaction by MarcoFalke)
   • #13307 (Replace coin selection fallback strategy with Single Random Draw by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   sipa commented at 5:38 pm on June 28, 2018: member

   utACK 60cf69ee7855b8d5c86d3ed41c47f764ccee5095. Nice simplification.
5. 
   laanwj commented at 11:55 am on July 10, 2018: member

   I wonder if this is slightly confusing as long as long as it still uses the type parameter in the rest of (de)serialization.

   Long term I do think that it makes sense to get rid of it altogether. Instead of passing a type into the serialization it’d be more clear to use a subclass or proxy object if different kinds of (de)serialization are wanted.

6. DrahtBot closed this on Aug 25, 2018

   ---

7. 
   DrahtBot commented at 8:55 pm on August 25, 2018: member
8. DrahtBot reopened this on Aug 25, 2018

   ---

9. DrahtBot added the label Needs rebase on Aug 29, 2018
10. Empact force-pushed on Aug 30, 2018
11. 
    Empact commented at 5:57 am on August 30, 2018: member

    Rebased for #13792
12. Empact force-pushed on Aug 30, 2018
13. DrahtBot removed the label Needs rebase on Aug 30, 2018
14. Drop unused GetType() from CSizeComputer da74db0940
15. Drop minor GetSerializeSize template

    Now that `GetType()` is not propagated, the benefits are not worth the code.

    893628be01
16. in src/serialize.h:906 in c77a66b551 outdated

    900@@ -901,10 +901,9 @@ class CSizeComputer
    901 protected:
    902     size_t nSize;
    903 
    904-    const int nType;
    905     const int nVersion;
    906 public:
    907-    CSizeComputer(int nTypeIn, int nVersionIn) : nSize(0), nType(nTypeIn), nVersion(nVersionIn) {}
    908+    CSizeComputer(int nVersionIn) : nSize(0), nVersion(nVersionIn) {}
    

    ---

    ---

    

    practicalswift commented at 7:46 pm on September 5, 2018:

    Should be explicit? :-)

    ---

    

    laanwj commented at 4:54 pm on September 10, 2018:

    yes, that’s good practice for one-argument constructors (sorry for fat fingering the resolve button)
17. Empact force-pushed on Sep 11, 2018
18. 
    Empact commented at 4:59 am on September 11, 2018: member

    Made the now single-arg constructor explicit
19. laanwj merged this on Sep 11, 2018
20. laanwj closed this on Sep 11, 2018

    ---

21. laanwj referenced this in commit bcffd8743e on Sep 11, 2018
22. Empact deleted the branch on Sep 23, 2018
23. 
    kallewoof commented at 1:32 am on October 6, 2018: member

    Edit: Removed. Not really fair of me to ask such a thing. Still not sure how to fix the code but will work it out myself.
24. furszy referenced this in commit 5c93f159bc on Jul 5, 2021
25. random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
26. MarcoFalke locked this on Sep 8, 2021

Contributors
Empact DrahtBot sipa laanwj practicalswift kallewoof

Labels
Refactoring