WIP: bitcoin-tx: Require that input amount is provided for witness transactions #13608

pull Empact wants to merge 1 commits into bitcoin:master from Empact:bitcoin-tx-sign-amount changing 1 files +5 −1

Empact commented at 1:06 AM on July 7, 2018: member

Applies fix from #12458 / #13547 to bitcoin-tx.
Require that input amount is provided for bitcoin-tx witness transactions 876f49c6cd
Empact commented at 1:08 AM on July 7, 2018: member

wip: needs testing.
fanquake deleted a comment on Jul 7, 2018
MarcoFalke added the label Utils/log/libs on Jul 7, 2018
MarcoFalke renamed this:
~~Require that input amount is provided for bitcoin-tx witness transactions~~
bitcoin-tx: Require that input amount is provided for witness transactions
on Jul 7, 2018
Empact commented at 3:40 PM on July 9, 2018: member

I'll re-open this after one of #12458 / #13547 goes in.
Empact closed this on Jul 9, 2018
MarcoFalke commented at 6:46 PM on July 11, 2018: member

wip: needs testing.

Jup, would be nice to add a test to the existing test cases.
luke-jr commented at 8:53 PM on July 29, 2018: member

#13547 went in; reopen?
Empact reopened this on Jul 29, 2018
luke-jr referenced this in commit 0fe5e01ef9 on Jul 30, 2018
Empact renamed this:
~~bitcoin-tx: Require that input amount is provided for witness transactions~~
WIP: bitcoin-tx: Require that input amount is provided for witness transactions
on Nov 12, 2018
DrahtBot commented at 8:35 PM on March 9, 2020: member

The last travis run for this pull request was 278 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.
DrahtBot closed this on Mar 9, 2020
DrahtBot reopened this on Mar 9, 2020
fanquake commented at 1:57 AM on June 9, 2021: member

@theStack you might be interested in reviewing this.
MarcoFalke commented at 3:31 PM on December 15, 2021: member

#23784
MarcoFalke closed this on Dec 15, 2021
MarcoFalke referenced this in commit 34118bfadd on Jan 5, 2022
sidhujag referenced this in commit aefcb9b11f on Jan 6, 2022
DrahtBot locked this on Dec 15, 2022

Contributors

Labels

Linked (view graph)

#12458 Enforce that amount is provided for signrawtransaction prevtxs #13547 Make signrawtransaction* give an error when amount is needed but missing #23784 bitcoin-tx: Require that input amount is provided for witness transactions