Typos in the install script #13618

pull stefek99 wants to merge 2 commits into bitcoin:master from stefek99:patch-1 changing 1 files +3 −1

stefek99 commented at 8:52 PM on July 9, 2018: none

Removing kind-of-obvious three dots.

Here is the mindless output of the original command.

./configure BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" ...
configure: WARNING: you should use --build, --host, --target
checking build system type... Invalid configuration `...': machine `...' not recognized
configure: error: /bin/sh build-aux/config.sub ... failed```

Typos in the install script

Removing kind-of-obvious three dots.

Here is the mindless output of the original command.

```./configure BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" ...
configure: WARNING: you should use --build, --host, --target
checking build system type... Invalid configuration `...': machine `...' not recognized
configure: error: /bin/sh build-aux/config.sub ... failed```

3c0b328d90

Empact commented at 10:40 PM on July 9, 2018: member

This isn't really a typo, it's an instruction in the documentation, meant to be interpreted rather than applied literally. IMO it's reasonable either way.
fanquake added the label Scripts and tools on Jul 10, 2018
fanquake commented at 1:46 AM on July 10, 2018: member

Agree it's not exactly a typo, but let's just drop the dots and remove any ambiguity.

utACK 3c0b328
laanwj commented at 12:39 PM on July 10, 2018: member

Tend to NACK this, I think the three dots are fine. THey just specify where the rest of the arguments has to go.
Removing ambiguity, adding clarification. 6b20bb53dc
MarcoFalke added the label Docs on Jul 11, 2018
promag commented at 3:23 PM on July 13, 2018: member

... is short and should be obvious for those that use these instructions. Agree with @laanwj.

-0
laanwj commented at 5:26 PM on July 13, 2018: member

Closing this - thanks for the contribution, but there isn't pressing reason to change this.
laanwj closed this on Jul 13, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Docs Scripts and tools