Remove mapRequest tracking that just effects Qt display. #13622

1. 
   TheBlueMatt commented at 7:06 am on July 10, 2018: member

   I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far.
2. Remove useless mapRequest tracking that just effects Qt display.

   I thought we had removed this a long time ago, TBH, its really
   confusing feedback to users that we display whether a tx was
   broadcast to immediate neighbor nodes, given that has little
   indication of whether the tx propagated very far.

   beef7ec4be
3. TheBlueMatt renamed this:
   Remove useless mapRequest tracking that just effects Qt display.
   Remove mapRequest tracking that just effects Qt display.
   on Jul 10, 2018
4. fanquake added the label GUI on Jul 10, 2018
5. 
   gmaxwell commented at 7:12 am on July 10, 2018: contributor

   ACK. I also thought so too. LGTM.
6. 
   jonasschnelli commented at 7:22 am on July 10, 2018: contributor

   utACK beef7ec4be725beea870a2da510d2817487601ec
7. 
   DrahtBot commented at 10:33 am on July 10, 2018: member

   • #10973 (Refactor: separate wallet from node by ryanofsky)
   • #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   laanwj commented at 11:43 am on July 10, 2018: member

   Concept ACK. I tried to remove it in the deep past: #3380. @sipa disagreed at the time, so let’s ask again.
9. laanwj added the label Wallet on Jul 10, 2018
10. 
    sipa commented at 3:18 pm on July 10, 2018: member

    @laanwj Heh, I don’t even remember anymore.

    Concept ACK, the current approach isn’t a good way to measure network propagation anyway.

11. 
    gmaxwell commented at 3:20 pm on July 10, 2018: contributor

    We’d want to do something different (which would also be much more effective and less confusing) after dandelion and/mempool sync is implemented, anyways.
12. 
    MarcoFalke commented at 3:42 pm on July 10, 2018: member

    utACK beef7ec4be725beea870a2da510d2817487601ec
13. 
    laanwj commented at 3:51 pm on July 10, 2018: member

    Concept ACK, the current approach isn’t a good way to measure network propagation anyway.

    Right, in one direction it is: if a transaction has not been requested by any other node, you can be sure it hasn’t propagated. But not the other way around.

14. 
    theuni commented at 5:45 pm on July 10, 2018: member

    utACK beef7ec4be725beea870a2da510d2817487601ec
15. laanwj merged this on Jul 11, 2018
16. laanwj closed this on Jul 11, 2018

    ---

17. laanwj referenced this in commit e538a952d5 on Jul 11, 2018
18. MarcoFalke referenced this in commit c04a4a5ae9 on Jul 12, 2018
19. 
    jtimon commented at 8:48 pm on July 21, 2018: contributor

    utACK beef7ec4be725beea870a2da510d2817487601ec
20. hebasto referenced this in commit cfc55edb6a on Oct 23, 2018
21. hebasto referenced this in commit 04972fefd1 on Oct 28, 2018
22. laanwj referenced this in commit 69d574ac6c on Nov 5, 2018
23. practicalswift referenced this in commit 2c7e11eb01 on Nov 5, 2018
24. HashUnlimited referenced this in commit 337c66a949 on Nov 5, 2018
25. jfhk referenced this in commit 575d0f52ad on Nov 14, 2018
26. JeremyRubin referenced this in commit f568eb4d2e on Nov 24, 2018
27. HashUnlimited referenced this in commit 910e036d63 on Nov 26, 2018
28. HashUnlimited referenced this in commit 47b53a3df6 on Jan 11, 2019
29. PastaPastaPasta referenced this in commit afb0dc0951 on Sep 9, 2020
30. UdjinM6 referenced this in commit df536f269a on Sep 12, 2020
31. PastaPastaPasta referenced this in commit 37af70a188 on Sep 12, 2020
32. ckti referenced this in commit f18f9adde1 on Mar 28, 2021
33. UdjinM6 referenced this in commit d4974381b6 on Jun 29, 2021
34. UdjinM6 referenced this in commit 7b3ccffa61 on Jun 29, 2021
35. UdjinM6 referenced this in commit a135e401f3 on Jul 1, 2021
36. UdjinM6 referenced this in commit 54c70b1502 on Jul 2, 2021
37. UdjinM6 referenced this in commit d499aed3c4 on Jul 2, 2021
38. Munkybooty referenced this in commit 947e131a36 on Jul 22, 2021
39. Munkybooty referenced this in commit c97c5798ae on Jul 22, 2021
40. Munkybooty referenced this in commit c0cbc650a3 on Jul 22, 2021
41. Munkybooty referenced this in commit 92631e279e on Jul 22, 2021
42. Munkybooty referenced this in commit 70c732ca03 on Jul 23, 2021
43. Munkybooty referenced this in commit 0ffd51035f on Jul 23, 2021
44. Munkybooty referenced this in commit 414e74ebca on Jul 23, 2021
45. Munkybooty referenced this in commit 4fa5aefe85 on Jul 23, 2021
46. Munkybooty referenced this in commit b31b607cc9 on Jul 26, 2021
47. Munkybooty referenced this in commit fdf5563fb9 on Jul 27, 2021
48. Munkybooty referenced this in commit ae6f3840c9 on Jul 28, 2021
49. MarcoFalke locked this on Sep 8, 2021

Contributors
TheBlueMatt gmaxwell jonasschnelli DrahtBot laanwj sipa MarcoFalke theuni jtimon

Labels
GUI Wallet