build: add missing leveldb defines #13659

1. 
   theuni commented at 8:48 pm on July 13, 2018: member

   Fixes #13585.

   src/leveldb/build_detect_platform shows how upstream defines them.

   These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

   Now that all possible platforms are enumerated, specifying an unknown one is an error.

2. build: add missing leveldb defines

   src/leveldb/build_detect_platform shows how upstream defines them.
   
   These platform may not be able to fully build or run Bitcoin, but defining all
   known to leveldb saves future hassle.
   
   Now that all possible platforms are enumerated, specifying an unknown one is an
   error.

   768981c93d
3. 
   MarcoFalke commented at 9:22 pm on July 13, 2018: member

   ACK 768981c93d8115d9515edd35e3c793b44f6192b4 (built src/bitcoind on SmartOS, which wasn’t possible previously. Didn’t check anything else)
4. 
   sipa commented at 9:31 pm on July 13, 2018: member

   utACK 768981c93d8115d9515edd35e3c793b44f6192b4
5. 
   Empact commented at 10:58 pm on July 13, 2018: member

   Noticed leveldb includes a build_detect_platform script, which includes these and other settings (e.g. handling of cygwin, -D_REENTRANT for various), should we be using the script directly instead? https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/build_detect_platform

   utACK 768981c

6. fanquake added the label Build system on Jul 13, 2018
7. 
   sipa commented at 11:38 pm on July 13, 2018: member

   @Empact Read the history here (https://github.com/bitcoin/bitcoin/pull/7911) about why we moved away from using LevelDB’s own build system.
8. 
   fanquake commented at 11:56 pm on July 13, 2018: member

   utACK 768981c
9. sipa merged this on Jul 14, 2018
10. sipa closed this on Jul 14, 2018

    ---

11. sipa referenced this in commit 90b1c7e5c5 on Jul 14, 2018
12. greenaddress referenced this in commit c41866bbe6 on Jul 20, 2018
13. greenaddress referenced this in commit 0766c6f3e7 on Jul 20, 2018
14. greenaddress referenced this in commit b2de467753 on Jul 20, 2018
15. greenaddress referenced this in commit 1331b77b68 on Aug 22, 2018
16. greenaddress referenced this in commit 5339318d9a on Aug 22, 2018
17. greenaddress referenced this in commit be2036c70a on Aug 22, 2018
18. greenaddress referenced this in commit d7ded83fec on Aug 22, 2018
19. greenaddress referenced this in commit 1b7e27310c on Aug 23, 2018
20. PastaPastaPasta referenced this in commit 92a6550b4f on Jul 19, 2020
21. PastaPastaPasta referenced this in commit db8327c2a8 on Jul 24, 2020
22. PastaPastaPasta referenced this in commit a1c8cac741 on Jul 27, 2020
23. UdjinM6 referenced this in commit e443c34ac1 on Jul 27, 2020
24. UdjinM6 referenced this in commit 545d157d14 on Jul 27, 2020
25. zkbot referenced this in commit ce5d8daae6 on Jan 25, 2021
26. gades referenced this in commit 6ecfacd026 on Jun 26, 2021
27. PastaPastaPasta referenced this in commit 727caa8d20 on Jun 27, 2021
28. PastaPastaPasta referenced this in commit b8a2358812 on Jun 28, 2021
29. PastaPastaPasta referenced this in commit 1aaa509013 on Jun 29, 2021
30. DrahtBot locked this on Sep 8, 2021

Contributors
theuni MarcoFalke sipa Empact fanquake

Labels
Build system