Bash completion for bitcoind(1) #1366

pull roques wants to merge 2 commits into bitcoin:master from roques:completion changing 4 files +118 −1

roques commented at 11:31 PM on May 20, 2012: contributor

Uses bitcoind --help to determine available options and bitcoind help to determine available commands. Currently placed in contrib/debian/bitcoind.bash-completion, so it can be picked up automatically by the Debian package building process.
gmaxwell commented at 11:36 PM on May 20, 2012: contributor

What does this do when the RPC server isn't running yet?

(I hate the completions that fedora ships and I always remove them— because they're out of date with the software, etc.. kinda interesting to poll the command)
roques commented at 3:12 PM on May 21, 2012: contributor

It comes up with an empty command list, which is correct. If one has not specified or configured how to access a running RPC-server there are no commands to issue.
TheBlueMatt commented at 11:42 AM on May 22, 2012: member

Could you also put it in contrib/debian/bitcoind.install so that it gets installed, or will it happen because its named *.bash-completion?
roques commented at 1:51 PM on May 22, 2012: contributor

Contrary to what I thought, installation is not fully automatic: One can add it to bitcoind.install (this branch), use bash-completion's debhelper (my branch completion-dh roques/bitcoin@e18f003b99cd4f0d0897328f6cc9257240a5962d), or ... What's to your taste?
gmaxwell commented at 3:03 PM on May 22, 2012: contributor

there are no commands to issue.

Well there are— as we have commandline parameters for the daemon itself, but not doing anything sounds like a safe and least surprising alternative.
TheBlueMatt commented at 3:54 PM on May 22, 2012: member

I would say use debhelper, seems more like "the debian way"(tm)
sipa commented at 8:58 PM on May 22, 2012: member

I'm not sure whether it should be in debian folder altogether? This is certainly useful to other distributions as well. ACK on adding such a file to our source tree, though.
roques commented at 9:01 PM on May 22, 2012: contributor

Pushed new version with an extra commit to use debhelper to install. I've kept the commits separate, as the bitcoind.bash-completion alone is useful for other distributions as well.
TheBlueMatt commented at 9:04 PM on May 22, 2012: member

We have two (very outdated) man pages in the debian folder (because they were originally written by the debian maintainer and are GPL), so it kinda makes sense to throw this there, but if there is a better place, the build scripts can just as easily pull them in.
laanwj commented at 5:17 AM on May 23, 2012: member

ACK, seems useful.
luke-jr commented at 5:48 AM on May 23, 2012: member

I disagree that it makes any sense to put this under debian/; bash completion is distro-independent.
TheBlueMatt commented at 12:34 PM on May 23, 2012: member

If there is a better place to put it, someone should suggest one, in any case ACK.
luke-jr commented at 1:51 PM on May 23, 2012: member

contrib/bitcoind.bash-completion
gavinandresen commented at 4:28 PM on May 23, 2012: contributor

ACK, nice additional functionality, don't care where it is put.
Bash programmable completion for bitcoind(1) 33d7d93298
Use debhelper to install bitcoind.bash-completion dbd9c486bb
roques commented at 7:33 PM on May 23, 2012: contributor

I've redone my branch to put bitcoind.bash-completion directly into contrib/ with a second commit to use debhelper to include it in the Debian package.
TheBlueMatt commented at 12:24 AM on May 24, 2012: member

ACK
gavinandresen referenced this in commit 325e5c3ef0 on May 25, 2012
gavinandresen merged this on May 25, 2012
gavinandresen closed this on May 25, 2012
coblee referenced this in commit 6cdb984195 on Jul 17, 2012
lateminer referenced this in commit 5d004d514c on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors