Docs: Control Port not always enabled by default #13681

pull JBaczuk wants to merge 2 commits into bitcoin:master from JBaczuk:torrc_config_doc_notes changing 1 files +11 −10

JBaczuk commented at 4:10 AM on July 17, 2018: contributor

added note that for tor to work in automatic mode, the control port must be enabled and also added how to do that by using torrc config file.
added note that control port must be enabled and how to do that in torrc config file 5030d69138
fanquake added the label Docs on Jul 17, 2018
fanquake commented at 6:40 AM on July 17, 2018: member

Please remove the trailing whitespace from the lines you've added. That is what's causing the tests to fail.

in doc/tor.md:106 in 5030d69138 outdated

 101 | @@ -102,8 +102,9 @@ and, if not disabled, configured using the `-torcontrol` and `-torpassword` sett
 102 |  To show verbose debugging information, pass `-debug=tor`.
 103 |  
 104 |  Connecting to Tor's control socket API requires one of two authentication methods to be 
 105 | -configured. For cookie authentication the user running bitcoind must have write access 
 106 | -to the `CookieAuthFile` specified in Tor configuration. In some cases this is 
 107 | +configured. It also requires the control socket to be enabled, eg. put `ControlPort 9051`
 108 | +in torrc config file. For cookie authentication the user running bitcoind must have write

practicalswift commented at 8:04 AM on July 17, 2018:

Nit: Use `torrc`

in doc/tor.md:105 in 5030d69138 outdated

 101 | @@ -102,8 +102,9 @@ and, if not disabled, configured using the `-torcontrol` and `-torpassword` sett
 102 |  To show verbose debugging information, pass `-debug=tor`.
 103 |  
 104 |  Connecting to Tor's control socket API requires one of two authentication methods to be 
 105 | -configured. For cookie authentication the user running bitcoind must have write access 
 106 | -to the `CookieAuthFile` specified in Tor configuration. In some cases this is 
 107 | +configured. It also requires the control socket to be enabled, eg. put `ControlPort 9051`

practicalswift commented at 8:04 AM on July 17, 2018:

Nit: "e.g."

added note that control port must be enabled and how to do that in torrc config file 714b5aa968
DrahtBot commented at 4:08 PM on July 17, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13255 (trivial: Fixed typos and cleaned up language by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in doc/tor.md:107 in 714b5aa968
```
 112 | -which has the appropriate permissions. An alternative authentication method is the use 
 113 | -of the `-torpassword` flag and a `hash-password` which can be enabled and specified in 
 114 | +Connecting to Tor's control socket API requires one of two authentication methods to be
 115 | +configured. It also requires the control socket to be enabled, e.g. put `ControlPort 9051`
 116 | +in `torrc` config file. For cookie authentication the user running bitcoind must have write
 117 | +access to the `CookieAuthFile` specified in Tor configuration. In some cases this is
```
laanwj commented at 4:14 PM on July 17, 2018:

This is not your doing, but I think this statement is not correct. It needs read access to the cookie file (to be able to send it for authentication), not write access.

kewde commented at 2:40 PM on July 20, 2018:

Seems like the author copied that wording from the tor spec. The user running the tor daemon needs the write access, and the user running bitcoind should only need read.

laanwj commented at 1:41 PM on July 25, 2018:

exactly

JBaczuk commented at 1:46 PM on August 31, 2018:

ok I've made this change, apologies, I didn't realize this was holding this PR up.
DrahtBot added the label Needs rebase on Aug 2, 2018
DrahtBot commented at 2:30 PM on August 2, 2018: member

Needs rebase
laanwj commented at 8:48 AM on August 31, 2018: member

Closing this, let me know if you want to pick it up again, but this is taking much too long for a documentation-only change
laanwj closed this on Aug 31, 2018
JBaczuk commented at 1:02 PM on August 31, 2018: contributor

Apologies, what exactly is holding this up?
MarcoFalke commented at 1:12 PM on August 31, 2018: member

@JBaczuk Could you please address the in-line feedback?
JBaczuk commented at 1:58 PM on August 31, 2018: contributor

@MarcoFalke oh, ok done.
MarcoFalke commented at 2:46 PM on August 31, 2018: member

This pull is still closed and it won't let me reopen due to the push.
JBaczuk commented at 3:01 PM on August 31, 2018: contributor

I didn't know that could happen, what's the proper procedure here?
MarcoFalke commented at 3:10 PM on August 31, 2018: member

There hasn't been any substantial discussion, so feel free to open a new pull request in this case.
JBaczuk commented at 3:17 PM on August 31, 2018: contributor

Ok reopened as #14120
laanwj referenced this in commit 68f3c7eb08 on Sep 2, 2018
laanwj removed the label Needs rebase on Oct 24, 2019
Munkybooty referenced this in commit bc8a903e1e on Jul 1, 2021
Munkybooty referenced this in commit f71e0aa00f on Jul 2, 2021
Munkybooty referenced this in commit 4c520b3c74 on Jul 3, 2021
UdjinM6 referenced this in commit 2619b7e806 on Jul 3, 2021
Munkybooty referenced this in commit f3d2167496 on Jul 3, 2021
UdjinM6 referenced this in commit c5269526fc on Jul 3, 2021
Munkybooty referenced this in commit b03ee2a854 on Jul 7, 2021
Munkybooty referenced this in commit ee60af0dc0 on Jul 7, 2021
Munkybooty referenced this in commit 38c6a595e3 on Jul 7, 2021
Munkybooty referenced this in commit 3f5588f0b7 on Jul 8, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#14120 Notes about control port and read access to cookie