And use it to reduce chainparamsbase.cpp's and remove interfaces/handler.cpp's reliance on util.h This is a step toward fixing the chainparamsbase -> util circular dependency.
Confirmed no need for the util.h include via iwyu and visual inspection. Extracted from #13639 for easier review.
Concept ACK
And use it to reduce chainparamsbase's direct reliance on util.h to
only args handling.
utilmemory.h can be replaced with <memory> once we move to C++14.
utACK 33539cb34b8f59b65387c142a46744fc83d3ed31
utACK 33539cb34b8f59b65387c142a46744fc83d3ed31
yes why not utACK 33539cb34b8f59b65387c142a46744fc83d3ed31
For the record, here's the relevant output from iwyu, as run by my fork here: https://github.com/Empact/include-what-you-use/tree/llvm-mac-os https://github.com/Empact/include-what-you-use/commit/5eba4e85e597d6906ba7f8942252ab0bd55c372f
(interfaces/handler.h has correct #includes/fwd-decls)
(interfaces/handler.cpp has correct #includes/fwd-decls)
make[2]: *** [interfaces/libbitcoin_util_a-handler.o] Error 2
CXX libbitcoin_util_a-utilstrencodings.o
chainparamsbase.h should remove these lines:
- #include <vector> // lines 10-10
The full include-list for chainparamsbase.h:
#include <memory> // for unique_ptr
#include <string> // for string
---
chainparamsbase.cpp should add these lines:
#include <stdexcept> // for runtime_error
The full include-list for chainparamsbase.cpp:
#include <chainparamsbase.h>
#include <assert.h> // for assert
#include <tinyformat.h> // for strprintf
#include <util.h> // for ArgsManager, gArgs, OptionsCategory, Options...
#include <utilmemory.h> // for MakeUnique
#include <stdexcept> // for runtime_error