Remove redundant variables, statements and forward declarations #13691

1. 
   practicalswift commented at 5:53 pm on July 17, 2018: contributor

   Remove redundant …

   • ~access modifiers,~
   • forward declarations,
   • unused variables,
   • statements, and
   • ~return types from lambdas.~
2. 
   Empact commented at 6:01 pm on July 17, 2018: member

   I’m unsure on 1d45dcd and dc0996f because they serve to help document the code.
3. practicalswift force-pushed on Jul 17, 2018
4. 
   MarcoFalke commented at 6:06 pm on July 17, 2018: member

   Agree with @Empact
5. 
   practicalswift commented at 6:08 pm on July 17, 2018: contributor

   @Empact Thanks for the quick review!

   I’ve now excluded dc0996f15ab99c8307bf63efd339cad20ddcb562 from this PR – I see your point.

   Regarding 1d45dcd67dbb7319e9acd6dd36ce7106727cb18a, what does that add from a documentation viewpoint? struct has public access to its base classes by default. Perhaps I’m missing something :-)

6. 
   Empact commented at 6:23 pm on July 17, 2018: member

   @practicalswift the value is modest, but the declaration makes the default explicit, removing an otherwise-required unit of knowledge for the reader. Avoids the risk of an inappropriate expectation or assumption, particularly relevant since struct and class differ in their defaults.
7. fanquake added the label Refactoring on Jul 17, 2018
8. Remove redundant forward declaration 66ed242343
9. Remove redundant unused variables 99be644966
10. Remove redundant statement 3dee4cc509
11. practicalswift force-pushed on Jul 18, 2018
12. practicalswift renamed this:
    Remove redundant variables, statements, access modifiers, forward declarations and return types
    Remove redundant variables, statements and forward declarations
    on Jul 18, 2018
13. 
    practicalswift commented at 7:40 am on July 18, 2018: contributor

    @Empact I see your point. I’ve now excluded that commit. @Empact @MarcoFalke Please re-review :-)
14. 
    promag commented at 3:54 pm on July 18, 2018: member

    utACK 3dee4cc.
15. 
    Empact commented at 4:24 pm on July 18, 2018: member

    utACK 3dee4cc
16. 
    greenaddress commented at 6:15 pm on July 20, 2018: contributor

    utACK 3dee4cc5098c6e9bcc13df9d6277478c8273a6cd
17. 
    MarcoFalke commented at 7:18 pm on July 20, 2018: member

    utACK 3dee4cc
18. fanquake added this to the "Mergeable" column in a project

    ---

19. 
    DrahtBot commented at 1:28 pm on July 22, 2018: member

    • #13429 (Return the script type from Solver by Empact)
    • #13226 (Optimize SelectCoinsBnB by tracking the selection by index rather than by position by Empact)
    • #13167 (Refactoring: optimize SelectCoinsBnB by martinus)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

20. MarcoFalke merged this on Jul 22, 2018
21. MarcoFalke closed this on Jul 22, 2018

    ---

22. MarcoFalke referenced this in commit 62baa28787 on Jul 22, 2018
23. fanquake removed this from the "Mergeable" column in a project

    ---

24. jasonbcox referenced this in commit 46b2cbc850 on Sep 27, 2019
25. PastaPastaPasta referenced this in commit 46d15cd7d3 on Feb 2, 2021
26. PastaPastaPasta referenced this in commit cab82cfe18 on Feb 4, 2021
27. practicalswift deleted the branch on Apr 10, 2021
28. gades referenced this in commit cc1b65737a on Mar 27, 2022
29. DrahtBot locked this on Aug 16, 2022

Contributors
practicalswift Empact MarcoFalke promag greenaddress DrahtBot

Labels
Refactoring