[test] Add coverage to estimaterawfee and estimatesmartfee #13693

pull Empact wants to merge 1 commits into bitcoin:master from Empact:test-estimatefee changing 3 files +68 −1
  1. Empact commented at 8:06 pm on July 17, 2018: member

    This adds light functional coverage to estimaterawfee - a subset of the testing applied to estimatesmartfee, and argument validation testing to both estimaterawfee and estimatesmartfee.

    One valid estimatesmartfee signature test is commented out because it fails currently.

    Extracted from #12940

  2. fanquake added the label Tests on Jul 17, 2018
  3. in test/functional/rpc_estimatefee.py:13 in 31d9069425 outdated
     8+   - estimatesmartfee
     9+   - estimaterawfee
    10+"""
    11+
    12+from test_framework.test_framework import BitcoinTestFramework
    13+from test_framework.util import *
    


    practicalswift commented at 7:29 am on July 18, 2018:
    Avoid wildcard imports :-)
  4. practicalswift commented at 7:30 am on July 18, 2018: contributor
    Concept ACK modulo removal of wildcard imports :-)
  5. Empact force-pushed on Jul 18, 2018
  6. Empact commented at 1:21 pm on July 18, 2018: member
    Removed wildcard imports. Thanks!
  7. DrahtBot added the label Needs rebase on Jul 24, 2018
  8. Empact force-pushed on Jul 25, 2018
  9. Empact commented at 2:53 pm on July 25, 2018: member
    Rebased for #12257
  10. DrahtBot removed the label Needs rebase on Jul 25, 2018
  11. DrahtBot commented at 2:00 pm on September 15, 2018: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  12. in test/functional/feature_fee_estimation.py:107 in 0f88f4d1dd outdated
    103+def check_raw_estimates(node, fees_seen):
    104+    """Call estimaterawfee and verify that the estimates meet certain invariants."""
    105+
    106+    delta = 1.0e-6  # account for rounding error
    107+    for i in range(1, 26):
    108+        for time_horizon, e in node.estimaterawfee(i).items():
    


    practicalswift commented at 8:21 pm on September 23, 2018:
    Nit: for _, e in node.estimaterawfee(i).items():

    Empact commented at 1:50 pm on October 9, 2019:
    Done 👍
  13. DrahtBot closed this on Apr 28, 2019

  14. DrahtBot commented at 7:11 pm on April 28, 2019: member
  15. DrahtBot reopened this on Apr 28, 2019

  16. DrahtBot added the label Needs rebase on Aug 2, 2019
  17. [test] Add coverage to estimaterawfee and estimatesmartfee
    This adds light functional coverage to estimaterawfee - a subset of
    the testing applied to estimatesmartfee, and argument validation
    testing to both estimaterawfee and estimatesmartfee.
    
    One valid estimatesmartfee signature test is commented out because it
    fails currently.
    111880aaf7
  18. Empact force-pushed on Oct 9, 2019
  19. Empact commented at 11:52 am on October 9, 2019: member
    Rebased, dropped unused reference in test
  20. DrahtBot removed the label Needs rebase on Oct 9, 2019
  21. MarcoFalke commented at 6:40 pm on March 11, 2020: member
    re-run ci
  22. MarcoFalke closed this on Mar 11, 2020

  23. MarcoFalke reopened this on Mar 11, 2020

  24. MarcoFalke merged this on Mar 11, 2020
  25. MarcoFalke closed this on Mar 11, 2020

  26. sidhujag referenced this in commit 4cf22d9d97 on Mar 11, 2020
  27. sidhujag referenced this in commit 1f01a50884 on Nov 10, 2020
  28. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me