contrib: correct version check #13699

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:contrib-py-zmq-version changing 2 files +2 −2

kallewoof commented at 6:37 AM on July 18, 2018: member

[ not(major >= 3 and minor >= 4) ] fails for '4.0':

>>> major=4
>>> minor=0
>>> if not (major >= 3 and minor >= 5):
...     print('This example only works with Python 3.5 and greater')
...
This example only works with Python 3.5 and greater

fanquake added the label Scripts and tools on Jul 18, 2018
ken2812221 commented at 6:54 AM on July 18, 2018: contributor

utACK 3cfce8f
practicalswift commented at 7:26 AM on July 18, 2018: contributor

utACK 3cfce8f23b37936a36cd386d47144bc725740391

contrib: correct version check

[ not(major >= 3 and minor >= 4) ] fails for '4.0'

066d2973a6

in contrib/zmq/zmq_sub.py:33 in 3cfce8f23b outdated

  29 | @@ -30,7 +30,7 @@
  30 |  import struct
  31 |  import sys
  32 |  
  33 | -if not (sys.version_info.major >= 3 and sys.version_info.minor >= 5):
  34 | +if not (sys.version_info.major > 3 or (sys.version_info.major == 3 and sys.version_info.minor >= 5)):

laanwj commented at 7:31 AM on July 18, 2018:

what about

if (sys.version_info.major, sys.version_info.minor) < (3, 5):

kallewoof commented at 7:45 AM on July 18, 2018:

What magic is this?

kallewoof force-pushed on Jul 18, 2018
practicalswift commented at 7:56 AM on July 18, 2018: contributor

utACK 066d2973a6fff0bf494c4a0000218fe72983808b
fanquake commented at 9:58 AM on July 18, 2018: member

utACK 066d297
laanwj commented at 12:51 PM on July 18, 2018: member

utACK 066d2973a6fff0bf494c4a0000218fe72983808b
laanwj merged this on Jul 18, 2018
laanwj closed this on Jul 18, 2018
laanwj referenced this in commit 4c6d1b9973 on Jul 18, 2018
kallewoof deleted the branch on Oct 17, 2019
PastaPastaPasta referenced this in commit b514e68a13 on Jul 19, 2020
PastaPastaPasta referenced this in commit 6156e515ae on Jul 24, 2020
PastaPastaPasta referenced this in commit 3c18fd2cbd on Jul 27, 2020
UdjinM6 referenced this in commit 30ebd2c161 on Jul 27, 2020
UdjinM6 referenced this in commit e867be596e on Jul 27, 2020
Fabcien referenced this in commit 5b71c10db3 on Oct 14, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels