Utils: Refactor ArgsManager a little #13733

pull AtsukiTak wants to merge 1 commits into bitcoin:master from AtsukiTak:tiny-refactor-args-manager changing 2 files +6 −6

AtsukiTak commented at 5:22 PM on July 21, 2018: contributor
This PR contains some small refactors for ArgsManager.
1. Mark const on member function if it possible.
2. Remove unused error argument from ArgsManager::IsArgKnown.
I'm not sure whether these refactors should be separated into another PR. If so, I will do that.
MarcoFalke commented at 5:46 PM on July 21, 2018: member

No need to have 3 commits for a 6 line change. Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
MarcoFalke added the label Refactoring on Jul 21, 2018
practicalswift commented at 5:50 PM on July 21, 2018: contributor

Concept ACK, but please squash

Thanks for a nice first-time contribution!

tiny refactor for ArgsManager

This commit contains 2 refactors.

1. mark "const" on ArgsManager::GetHelpMessage and IsArgKnown.
2. remove unused "error" argument from ArgsManager::IsArgKnown.

Firstly, I mark "const" on where it is possible to. It is mentioned
before (e.g. https://github.com/bitcoin/bitcoin/pull/13190#pullrequestreview-118823133).

And about 2nd change, ArgsManager::IsArgKnown was added at commit #4f8704d which was
merged at PR #13112. But from its beggining, "error" argument never be used.
I think it should be refactored.

9544a3f3fc

AtsukiTak force-pushed on Jul 21, 2018
AtsukiTak commented at 6:28 PM on July 21, 2018: contributor

Squashed. Thanks for reviews!
Empact commented at 9:05 PM on July 21, 2018: member

utACK 9544a3f
sipa commented at 9:08 PM on July 21, 2018: member

Concept ACK
promag commented at 12:59 AM on July 22, 2018: member

utACK 9544a3f — nice catch.
MarcoFalke commented at 2:29 AM on July 22, 2018: member

utACK 9544a3f
fanquake added this to the "Mergeable" column in a project

laanwj commented at 2:09 PM on July 22, 2018: member

utACK 9544a3f3fc5d900fbf90c5347821a7fcafc058b0
laanwj merged this on Jul 22, 2018
laanwj closed this on Jul 22, 2018
laanwj referenced this in commit 0d1ebf4d3f on Jul 22, 2018
fanquake removed this from the "Mergeable" column in a project

UdjinM6 referenced this in commit c260bca0ef on Jun 29, 2021
UdjinM6 referenced this in commit 4561063cfa on Jun 29, 2021
UdjinM6 referenced this in commit cf895d9c2e on Jul 1, 2021
UdjinM6 referenced this in commit 2e24744e46 on Jul 2, 2021
UdjinM6 referenced this in commit e55d7fc2c6 on Jul 2, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels