scripted-diff: Remove trailing whitespaces #13753

1. 
   promag commented at 3:09 pm on July 24, 2018: member

   The script test/lint/lint-whitespace.sh should prevent new cases.

   This happens in some pulls where the code editor and the author ‘git add’s them, so this would fix it all.

2. 
   Sjors commented at 3:15 pm on July 24, 2018: member

   Ironically rejected by a linter :-)

   Concept ACK: means I can turn “remove trailing whitespace” on again in my editor, without it changing stuff all over the file.

3. promag force-pushed on Jul 24, 2018
4. 
   promag commented at 3:24 pm on July 24, 2018: member

   means I can turn “remove trailing whitespace” on again in my editor, without it changing stuff all over the file

   Right, or skip hunks. Or this #13248 (review).

5. 
   MarcoFalke commented at 3:54 pm on July 24, 2018: member

   ACK b3ce5956291cd25ddb654e1dfb543658f87cdeb1, any difference between [[:space:]][[:space:]]* and [[:space:]]+?
6. promag force-pushed on Jul 24, 2018
7. 
   promag commented at 4:02 pm on July 24, 2018: member

   @MarcoFalke in order to use + extended regular expressions must be used. Updated to use them.
8. 
   MarcoFalke commented at 4:06 pm on July 24, 2018: member

   Note that the flag for gnu sed is --regexp-extended, not -E and for git it is --extended-regexp :p
9. promag force-pushed on Jul 24, 2018
10. 
    MarcoFalke commented at 5:21 pm on July 24, 2018: member

    You’d have to remove the trailing '' after the -i option, no?
11. scripted-diff: Remove trailing whitespaces

    -BEGIN VERIFY SCRIPT-
    
    sed --in-place'' --regexp-extended 's/[[:space:]]+$//g' $(git grep -I --files-with-matches --extended-regexp '[[:space:]]+$' -- src test  ':!*.svg' ':!src/crypto/sha256_sse4*' ':!src/leveldb' ':!src/qt/locale' ':!src/secp256k1' ':!src/univalue')
    
    -END VERIFY SCRIPT-

    12dd101345
12. promag force-pushed on Jul 24, 2018
13. 
    promag commented at 8:31 pm on July 24, 2018: member

    @MarcoFalke done :feelsgood:
14. 
    mess110 commented at 9:50 pm on July 24, 2018: contributor

    utACK 12dd101
15. fanquake added the label Scripts and tools on Jul 24, 2018
16. 
    MarcoFalke commented at 11:50 pm on July 24, 2018: member

    utACK 12dd1013454a3b4913e8e6bbac251887e7e82ff0
17. MarcoFalke added the label Refactoring on Jul 24, 2018
18. MarcoFalke removed the label Scripts and tools on Jul 24, 2018
19. 
    DrahtBot commented at 11:53 pm on July 24, 2018: member

    • #13529 (Use new Qt5 connect syntax by promag)
    • #10785 (Serialization improvements by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

20. 
    fanquake commented at 11:03 am on July 25, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/13753/commits/12dd1013454a3b4913e8e6bbac251887e7e82ff0

    Have not checked the scripted diff or if this is has removed all the trailing whitespace, but if according to @DrahtBot this doesn’t disrupt much else, LJGTM.

21. fanquake added this to the "Mergeable" column in a project

    ---

22. MarcoFalke merged this on Jul 25, 2018
23. MarcoFalke closed this on Jul 25, 2018

    ---

24. MarcoFalke referenced this in commit a140953907 on Jul 25, 2018
25. fanquake removed this from the "Mergeable" column in a project

    ---

26. 
    Empact commented at 2:45 pm on July 25, 2018: member

    So glad this is done. Thanks @promag!
27. PastaPastaPasta referenced this in commit c49e506176 on Jul 29, 2020
28. DrahtBot locked this on Sep 8, 2021

Contributors
promag Sjors MarcoFalke mess110 DrahtBot fanquake Empact

Labels
Refactoring