gui: Don't access static members from class instances #13768

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:dont-access-static-members-from-class-instances changing 4 files +5 −5

practicalswift commented at 2:52 PM on July 26, 2018: contributor

Don't access static members from class instances.

Be explicit about the fact that the members we're accessing are static.
Don't access static members from class instances 54e5ebc463
practicalswift commented at 2:59 PM on July 26, 2018: contributor

After posting this PR I see that the Qt documentation has an example with app.exec();. Am I mistaken here? :-)
MarcoFalke renamed this:
~~Don't access static members from class instances~~
gui: Don't access static members from class instances
on Jul 26, 2018
MarcoFalke added the label GUI on Jul 26, 2018
MarcoFalke added the label Refactoring on Jul 26, 2018
DrahtBot commented at 4:56 PM on July 26, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13787 (Test for #13426 by ken2812221)
- #13426 ([bugfix] Fix encoding issue for Windows by ken2812221)
- #11625 (WIP: Add BitcoinApplication & RPCConsole tests by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Empact commented at 10:16 PM on July 26, 2018: member

I'm not sure this is an improvement...
practicalswift commented at 10:26 PM on July 26, 2018: contributor

@Empact That could that could very well be the case, but please help me understand why you think so :-)
sipa commented at 10:49 PM on July 26, 2018: member

I believe this is generally a good idea.
promag commented at 1:57 PM on July 27, 2018: member

Concept ACK.

Are these the only cases?
practicalswift commented at 4:43 PM on July 27, 2018: contributor

@promag Yes AFAIK :-)
laanwj commented at 11:17 AM on July 30, 2018: member

I'm not sure this is an improvement...

Me neither TBH. Let's not make changes just to make changes!

Please illustrate how this avoids bugs, otherwise I don't see the point. Currently it's possible to change the class and the calls will go to exactly the right class.
practicalswift commented at 12:08 PM on July 30, 2018: contributor

Closing due to lack of consensus ACK :-)
practicalswift closed this on Jul 30, 2018
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels