Mark single-argument constructors explicit.
Rationale:
From the developer notes:
By default, declare single-argument constructors explicit. Rationale: This is a precaution to avoid unintended conversions that might arise when single-argument constructors are used as implicit conversion functions.
Would be nice if explicit was the default for constructors unless you specify otherwise, but I guess we are stuck with cpp currently works.
Is there was a flag for a compile time warning or similar at least?
Concept ACK (unexpected implicit promotions are bad and 9 lines is OK), assuming there is a compile flag or non-false-positive-inducing linter that can plug this.
Forgot to include this excerpt from the developer notes:
By default, declare single-argument constructors explicit.
Rationale: This is a precaution to avoid unintended conversions that might arise when single-argument constructors are used as implicit conversion functions.
utACK 1ac3c983bfe06f75542e4f4e30142952802a46d8
utACK 1ac3c98. Are there more candidates?
@promag Thanks for reviewing! These should be all AFAIK :-)
utACK 1ac3c983bfe06f75542e4f4e30142952802a46d8
Ready for merge? :-)