doc: Remove newlines from error message #13775

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:addition-assignment-operator changing 2 files +3 −3

practicalswift commented at 10:11 PM on July 26, 2018: contributor

Fix accidental use of the addition assignment operator (+=).

Note to reviewers: Perhaps the \n:s should be removed too?
Empact commented at 10:17 PM on July 26, 2018: member

Looks like there is only one other call that uses a newline, and this is going into ThreadSafeMessageBox, so I expect they're unnecessary.
practicalswift commented at 10:30 PM on July 26, 2018: contributor

@Empact Now removing newlines as well :-)
Empact commented at 10:43 PM on July 26, 2018: member

How about also remove the last of the 3, in init.cpp? (found via /InitError\(.+\\n/)

That would also be an easy case to test how these look without newlines, because you can set the blocksdir to a non-existent location.
practicalswift force-pushed on Jul 26, 2018
practicalswift commented at 11:01 PM on July 26, 2018: contributor

@Empact Thanks! Now fixed. Please re-review :-)
fanquake added the label Refactoring on Jul 27, 2018

Empact commented at 2:41 PM on July 27, 2018: member

Tested ACK ee34012 Before:

$ src/bitcoind -blocksdir=somenonsense
Error: Specified blocks directory "somenonsense" does not exist.

$

After:

$ src/bitcoind -blocksdir=somenonsense
Error: Specified blocks directory "somenonsense" does not exist.
$

MarcoFalke commented at 3:37 PM on July 27, 2018: member

utACK ee34012c5bf590d17abc848b7ec2367816b63d14
MarcoFalke renamed this:
~~wallet: Fix accidental use of the addition assignment operator ("+=")~~
Remove newlines from error message
on Jul 27, 2018
MarcoFalke added the label Docs on Jul 27, 2018
MarcoFalke renamed this:
~~Remove newlines from error message~~
doc: Remove newlines from error message
on Jul 27, 2018
MarcoFalke commented at 3:40 PM on July 27, 2018: member

Please squash your commits.
Fix accidental use of the addition assignment operator ("+="). Remove newlines from error message. 620361fce8
practicalswift force-pushed on Jul 27, 2018
practicalswift commented at 4:47 PM on July 27, 2018: contributor

@MarcoFalke Squashed – please re-review :-)
Empact commented at 4:50 PM on July 27, 2018: member

utACK 620361f
promag commented at 6:37 PM on July 27, 2018: member

utACK 620361f.

Not all errors terminate with ., could be improved in a different PR?
MarcoFalke merged this on Jul 27, 2018
MarcoFalke closed this on Jul 27, 2018
MarcoFalke referenced this in commit ef4fac0ea5 on Jul 27, 2018
jasonbcox referenced this in commit 0cf84c37bc on Dec 20, 2019
PastaPastaPasta referenced this in commit 72d13461f1 on Sep 27, 2020
PastaPastaPasta referenced this in commit cc3f45448d on Sep 27, 2020
PastaPastaPasta referenced this in commit af08c75579 on Oct 14, 2020
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit a653862a67 on Mar 27, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels