build: Add missing [[noreturn]] to handleRunawayException(...). Enable -Wsuggest-attribute=noreturn if available. #13795

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:handleRunawayException changing 2 files +5 −4

practicalswift commented at 7:07 PM on July 29, 2018: contributor
- Add missing [[noreturn]] to handleRunawayException(…)
- Enable -Wsuggest-attribute=noreturn if available
fanquake added the label Build system on Jul 29, 2018

fanquake commented at 4:11 AM on July 30, 2018: member

macOS travis:

  CXXLD    test/test_bitcoin_fuzzy
  CXXLD    bitcoind
qt/bitcoin.cpp:527:3: error: function declared '[[noreturn]]' after its first declaration
[[noreturn]] void BitcoinApplication::handleRunawayException(const QString &message)
  ^
qt/bitcoin.cpp:215:10: note: declaration missing '[[noreturn]]' attribute is here
    void handleRunawayException(const QString &message);
         ^
1 error generated.
Makefile:8653: recipe for target 'qt/qt_bitcoin_qt-bitcoin.o' failed

practicalswift force-pushed on Jul 30, 2018
qt: Mark BitcoinApplication::handleRunawayException(...) noreturn c992d0c31c
build: Suggest noreturn attributes where appropriate c9f067ed21
practicalswift force-pushed on Jul 30, 2018
DrahtBot commented at 12:00 PM on July 30, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #11625 (WIP: Add BitcoinApplication & RPCConsole tests by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
practicalswift closed this on Jul 30, 2018
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels