[0.16] Make signrawtransaction give an error when amount is needed but missing #13796

1. 
   luke-jr commented at 8:28 PM on July 29, 2018: member

   Backport of #13547 to 0.16

2. Error on missing amount in signrawtransaction*

   Signatures using segregated witness commit to the amount being spent,
   so that value must be passed into signrawtransactionwithkey and
   signrawtransactionwithwallet. This ensures an error is issued if that
   doesn't happen, rather than just assuming the value is 0 and producing
   a signature that is almost certainly invalid.
   
   Github-Pull: #13547
   Rebased-From: a3b065b51fb333d976108a1fe34b7f663fd67285

   1825e37075
3. [tests] Check signrawtransaction* errors on missing prevtx info

   Github-Pull: #13547
   Rebased-From: 685d1d8115f61b15115d80523dd8273f0a816534

   212ef1f954
4. 
   Empact commented at 11:14 PM on July 29, 2018: member

   utACK 212ef1f

5. fanquake added the label Backport on Jul 30, 2018
6. fanquake added this to the milestone 0.16.x on Jul 30, 2018
7. 
   fanquake commented at 1:17 AM on August 1, 2018: member

   utACK 212ef1f

8. 
   Sjors commented at 2:28 PM on August 2, 2018: member

   utACK 212ef1f, and functional test passes on macOS.

9. fanquake added this to the "Mergeable" column in a project

---

10. laanwj merged this on Aug 8, 2018
11. laanwj closed this on Aug 8, 2018

    ---

12. laanwj referenced this in commit b64f02fcfa on Aug 8, 2018
13. 
    laanwj commented at 10:30 AM on August 8, 2018: member

    utACK 212ef1f9547e27295a94eaa9d5ae552d858e2d9f

14. fanquake removed this from the "Mergeable" column in a project

---

15. DrahtBot locked this on Sep 8, 2021

Contributors

luke-jrEmpactfanquakeSjorslaanwj

Milestone
0.16.x