doc: add note to contributor docs about warranted PR's #13803

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:devnotes-warranted-change changing 1 files +2 −0

kallewoof commented at 1:54 PM on July 30, 2018: member

No description provided.
fanquake added the label Docs on Jul 30, 2018
kallewoof force-pushed on Jul 30, 2018
laanwj commented at 2:17 PM on July 30, 2018: member

ACK
fanquake commented at 2:17 PM on July 30, 2018: member

Thanks, utACK c72aa1f
kallewoof renamed this:
~~doc: add note to developer docs about warranted PR's~~
doc: add note to contributor docs about warranted PR's
on Jul 30, 2018
practicalswift commented at 2:19 PM on July 30, 2018: contributor

ACK
fanquake added this to the "Mergeable" column in a project

promag commented at 2:39 PM on July 30, 2018: member

ACK 3431e1a.
doc: add note to contributor docs about warranted PR's db213aa47f

in CONTRIBUTING.md:122 in 3431e1aff7 outdated

 118 | @@ -119,6 +119,8 @@ At this stage one should expect comments and review from other contributors. You
 119 |  can add more commits to your pull request by committing them locally and pushing
 120 |  to your fork until you have satisfied all feedback.
 121 |  
 122 | +Note: Code review is a burdensome but important part of the developer process, and as such, certain types of pull requests are rejected. In general, if the **improvements** do not warrant the **review effort** required, the PR has a high chance of being rejected. It is up to the PR author to convince the reviewers that the changes warrant the review effort, and if reviewers are "Concept NAK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes.

promag commented at 2:40 PM on July 30, 2018:

nit, ... the development process, ...

kallewoof commented at 2:48 PM on July 30, 2018:

Thanks, fixed.

kallewoof force-pushed on Jul 30, 2018
fanquake removed this from the "Mergeable" column in a project

practicalswift commented at 2:51 PM on July 30, 2018: contributor

ACK db213aa47f6c9a2f3945ddd14f5912f1e8b9c9fc
jonasschnelli commented at 3:07 PM on July 30, 2018: contributor

ACK db213aa47f6c9a2f3945ddd14f5912f1e8b9c9fc
MarcoFalke merged this on Jul 30, 2018
MarcoFalke closed this on Jul 30, 2018
MarcoFalke referenced this in commit feb7dd93d1 on Jul 30, 2018
kallewoof deleted the branch on Jul 30, 2018
PastaPastaPasta referenced this in commit d9a6fc7a5d on Jun 27, 2021
PastaPastaPasta referenced this in commit 27e6ebddb7 on Jun 28, 2021
PastaPastaPasta referenced this in commit 435fe3c2c6 on Jun 29, 2021
PastaPastaPasta referenced this in commit f337726fa1 on Jun 29, 2021
PastaPastaPasta referenced this in commit f1942b8f89 on Jun 29, 2021
PastaPastaPasta referenced this in commit 5698ebb7fe on Jun 29, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels