Remove unused qt nullptr args #13841

pull Empact wants to merge 1 commits into bitcoin:master from Empact:unused-nullptr-args changing 7 files +9 −11

Empact commented at 9:19 PM on August 1, 2018: member

In all cases these were either unreferenced or equal to the default value of the base class's constructor. I.e.: http://doc.qt.io/qt-5/qwidget.html#QWidget http://doc.qt.io/qt-5/qmainwindow.html#QMainWindow

Found via zero-as-null-ptr-constant warnings.
fanquake added the label Refactoring on Aug 1, 2018

Remove unused qt nullptr args

In all cases these were either unreferenced or equal to the default value of
the base class's constructor. E.g.:
http://doc.qt.io/qt-5/qwidget.html#QWidget
http://doc.qt.io/qt-5/qmainwindow.html#QMainWindow

Found via zero-as-null-ptr-constant warnings.

c7b35535a8

Empact force-pushed on Aug 2, 2018
practicalswift commented at 7:41 AM on August 2, 2018: contributor

utACK c7b35535a80bbfff2060b3b01a2fa4a6137c16ca

Thanks for taking your time to do these cleanups! Keep up the good work!
donaloconnor commented at 9:46 PM on August 3, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/commit/c7b35535a80bbfff2060b3b01a2fa4a6137c16ca 👍
laanwj commented at 2:35 PM on August 7, 2018: member

There's kind of an unwritten rule that derivations of QT widgets should take a parent* argument as last argument, so that they can in principle be embedded into another widget or be dependent on it for freeing. Even though we might not be using it right now. So I'm not sure this is an improvement or not.
DrahtBot commented at 10:12 PM on August 13, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13961 (util: Replace boost::signals2 with std::function by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 7:06 PM on August 23, 2018: member

Can be closed if there is no agreement to do this?
promag commented at 7:16 PM on August 23, 2018: member

+1 close.
Empact closed this on Aug 23, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels