clientversion: Define only macros we’ll use #13897

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-unused-macros changing 1 files +5 −12
  1. practicalswift commented at 9:25 PM on August 6, 2018: contributor

    Define only macros we'll use.

  2. fanquake added the label Refactoring on Aug 6, 2018
  3. kallewoof commented at 4:24 AM on August 7, 2018: member

    Is there even a point in having the define, rather than just putting it in the #define BUILD_DESC directly?

  4. practicalswift commented at 7:57 AM on August 7, 2018: contributor

    @kallewoof Good point! Now defining BUILD_DESC directly. Please re-review :-)

  5. ken2812221 commented at 4:03 AM on August 8, 2018: contributor

    Use bitcoin-cli --version to test

    87af43b:

    Bitcoin Core RPC client version vCLIENT_VERSION_MAJOR.CLIENT_VERSION_MINOR.CLIENT_VERSION_REVISION.CLIENT_VERSION_BUILD-BUILD_SUFFIX

    f46b747247:

    Bitcoin Core RPC client version v0.16.99.0-f46b747247

    master (9d86aad287):

    Bitcoin Core RPC client version v0.16.99.0-9d86aad287

    The second commit should be dropped. Tested ACK f46b747247

  6. Empact commented at 5:04 PM on August 11, 2018: member

    How about building the three off a common define?:

    #define BUILD_DESC_VERSION(maj, min, rev, build) \
    "v" DO_STRINGIZE(maj) "." DO_STRINGIZE(min) "." DO_STRINGIZE(rev) "." DO_STRINGIZE(build)

    This would reduce duplication and make the suffix more visible in the code.

  7. practicalswift force-pushed on Aug 13, 2018
  8. practicalswift commented at 12:02 PM on August 13, 2018: contributor

    @Empact Now using a common define. Please review :-) @ken2812221 Please re-review :-)

  9. Empact commented at 5:19 PM on August 13, 2018: member

    Just realized you can inline the arguments to BUILD_DESC_VERSION, so that the implementations are like BUILD_DESC_VERSION "-" BUILD_SUFFIX - would be much clearer IMO.

  10. Define only macros we'll use 21cd1da108
  11. practicalswift force-pushed on Aug 14, 2018
  12. practicalswift commented at 8:28 AM on August 14, 2018: contributor

    @Empact Updated. Please re-review :-)

  13. MarcoFalke added the label Needs gitian build on Sep 20, 2018
  14. MarcoFalke commented at 8:18 PM on September 20, 2018: member

    Not sure if this is worth it. I doubt we have enough reviewers that are fluent enough in macros that can review this.

  15. DrahtBot commented at 12:22 PM on September 21, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 9a3a984bb884c1153866b64845db7300121966b3 (master):

    Gitian builds for commit de395a30370fab9cce8e67629f386db6872a2071 (master and this pull):

  16. DrahtBot removed the label Needs gitian build on Sep 21, 2018
  17. practicalswift closed this on Oct 18, 2018
  18. practicalswift deleted the branch on Apr 10, 2021
  19. DrahtBot locked this on Aug 18, 2022
Contributors
practicalswiftkallewoofken2812221EmpactMarcoFalkeDrahtBot
Labels
Refactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me