Salvaged from #12138, and adjusted to current test framework conventions.
Block index inconsistencies are one of the most critical types of bugs we could see. Making sure we get good coverage of CheckBlockIndex() is pretty important (and there is minimal, if any performance difference in a default run).
Test suite on master takes 928-988 seconds on my machine, with this change it takes 901-1045 seconds (n=2, and not a perfect experimental setup).
Block index inconsistencies are one of the most critical types of
bugs we could see. Making sure we get good coverage of
CheckBlockIndex() is pretty important (and there is minimal, if any
performance difference in a default run).
utACK 9f47bde3f727c99c108751bf0b0237a7dde2a224
Note that we enable tx pool consistency checks for regtest by default and regtest is the network used by the test framework. So an alternative could be to enable it by default for regtest. Though, the current patch is already a clear improvement.
For reference the help text of the bool arg:
0 -checkblockindex
1 Do a full consistency check for mapBlockIndex, setBlockIndexCandidates,
2 chainActive and mapBlocksUnlinked occasionally. (default: 0)
I agree with @MarcoFalke - ideally, these checks should be enabled for regtest net automatically, similar to the mempool checks. That seems much cleaner to me than enabling them using command-line arguments (because those can be forgotten / acidentally removed more easily).
Concept ACK to running the checks regularly on regtest.
As noted by @MarcoFalke in #13913, checkblockindex is active by default on regtest.
Labels
Tests