qa: Restore wildcard import for messages in mininode #13975

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-qaWild changing 2 files +2 −3

MarcoFalke commented at 11:57 PM on August 14, 2018: member

mininode would always import all messages, so listing them individually as imports is redundant and verbose.
qa: Restore wildcard import for messages in mininode bccccc8d87
MarcoFalke added the label Tests on Aug 14, 2018

in test/functional/test_framework/mininode.py:24 in bccccc8d87

  20 | @@ -21,7 +21,7 @@
  21 |  import sys
  22 |  import threading
  23 |  
  24 | -from test_framework.messages import CBlockHeader, MIN_VERSION_SUPPORTED, msg_addr, msg_block, MSG_BLOCK, msg_blocktxn, msg_cmpctblock, msg_feefilter, msg_getaddr, msg_getblocks, msg_getblocktxn, msg_getdata, msg_getheaders, msg_headers, msg_inv, msg_mempool, msg_ping, msg_pong, msg_reject, msg_sendcmpct, msg_sendheaders, msg_tx, MSG_TX, MSG_TYPE_MASK, msg_verack, msg_version, NODE_NETWORK, NODE_WITNESS, sha256
  25 | +from test_framework.messages import *  # noqa

Empact commented at 5:44 AM on August 15, 2018:

Could disable just the specific rule here: # noqa: F405

in test/lint/lint-python.sh:34 in bccccc8d87

  30 | @@ -31,7 +31,6 @@ export LC_ALL=C
  31 |  # E401 multiple imports on one line
  32 |  # E402 module level import not at top of file
  33 |  # F403 'from foo_module import *' used; unable to detect undefined names
  34 | -# F405 foo_function may be undefined, or defined from star imports: bar_module

Empact commented at 5:45 AM on August 15, 2018:

If you disable the rule just where it's incoherent, then you can leave this active for other uses.

practicalswift commented at 10:15 AM on August 15, 2018: contributor

@MarcoFalke How do you mean redundant? Isn't this just a case of explicit vs implicit? Let me know if I'm missing some obvious win here :-)
laanwj commented at 1:36 PM on August 15, 2018: member

I hoped now that this river was crossed, we could leave it behind, let's not go back and forth on it
MarcoFalke closed this on Aug 15, 2018
MarcoFalke deleted the branch on Aug 15, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels