[doc] Add new regtest ports in man following #10825 ports reattributions

ariard commented at 0:01 am on August 21, 2018: member

Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it’s puzzling to guess why your regtest JSON-rpc connections all failed even if you’re following the docs.

fanquake added the label Docs on Aug 21, 2018

hebasto commented at 0:49 am on August 21, 2018: member

Manpages are generated from the help outputs. So consider to change the bitcoind -help output rather the bitcoind manpage please.

ariard force-pushed on Aug 22, 2018

ariard commented at 2:01 am on August 22, 2018: member

Updated+rebased

DrahtBot commented at 5:48 am on August 22, 2018: member

#14100 (doc: Change documentation for =0 for non-boolean options by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

MarcoFalke commented at 1:04 pm on August 22, 2018: member

ACK. Could you do the same for checkblockindex and checkmempool, please?

ariard force-pushed on Aug 23, 2018

ariard commented at 1:51 am on August 23, 2018: member

Updated and rebased, checkmempool regtest is 1 right ?

in src/init.cpp:458 in 26f9609daf outdated

453@@ -452,8 +454,8 @@ void SetupServerArgs()
454 
455     gArgs.AddArg("-checkblocks=<n>", strprintf("How many blocks to check at startup (default: %u, 0 = all)", DEFAULT_CHECKBLOCKS), true, OptionsCategory::DEBUG_TEST);
456     gArgs.AddArg("-checklevel=<n>", strprintf("How thorough the block verification of -checkblocks is (0-4, default: %u)", DEFAULT_CHECKLEVEL), true, OptionsCategory::DEBUG_TEST);
457-    gArgs.AddArg("-checkblockindex", strprintf("Do a full consistency check for mapBlockIndex, setBlockIndexCandidates, chainActive and mapBlocksUnlinked occasionally. (default: %u)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
458-    gArgs.AddArg("-checkmempool=<n>", strprintf("Run checks every <n> transactions (default: %u)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
459+    gArgs.AddArg("-checkblockindex", strprintf("Do a full consistency check for mapBlockIndex, setBlockIndexCandidates, chainActive and mapBlocksUnlinked occasionally. (default: %u, regtest: 1)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
460+    gArgs.AddArg("-checkmempool=<n>", strprintf("Run checks every <n> transactions (default: %u, regtest: 1)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);

MarcoFalke commented at 2:02 am on August 23, 2018:

Would prefer to use (reg)testnetChainParams here instead of hardcoding

Add new regtest ports in doc following #10825 ports reattributions

Add checkmempool and checkblockindex regtest true in doc

e8c4a1e369

ariard force-pushed on Aug 23, 2018

ariard commented at 3:17 am on August 23, 2018: member

Yes sure! done

randolf approved

MarcoFalke commented at 4:06 pm on August 23, 2018: member

utACK e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe

fanquake commented at 1:22 am on September 3, 2018: member

tACK https://github.com/bitcoin/bitcoin/pull/14013/commits/e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe

master (https://github.com/bitcoin/bitcoin/commit/68f3c7eb080e461cfeac37f8db7034fe507241d0):

 0src/bitcoin-cli -?
 1-rpcport=<port>
 2       Connect to JSON-RPC on <port> (default: 8332 or testnet: 18332)
 3
 4src/bitcoind -? -help-debug
 5-port=<port>
 6       Listen for connections on <port> (default: 8333 or testnet: 18333)
 7-checkblockindex
 8       Do a full consistency check for mapBlockIndex, setBlockIndexCandidates,
 9       chainActive and mapBlocksUnlinked occasionally. (default: 0)
10-checkmempool=<n>
11       Run checks every <n> transactions (default: 0)
12-rpcport=<port>
13       Listen for JSON-RPC connections on <port> (default: 8332 or testnet:
14       18332)

https://github.com/bitcoin/bitcoin/pull/14013/commits/e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe:

 0src/bitcoin-cli -?
 1-rpcport=<port>
 2       Connect to JSON-RPC on <port> (default: 8332, testnet: 18332, regtest:
 3       18443)
 4
 5src/bitcoind -? -help-debug
 6-port=<port>
 7       Listen for connections on <port> (default: 8333, testnet: 18333,
 8       regtest: 18444)
 9-checkblockindex
10       Do a full consistency check for mapBlockIndex, setBlockIndexCandidates,
11       chainActive and mapBlocksUnlinked occasionally. (default: 0,
12       regtest: 1)
13-checkmempool=<n>
14       Run checks every <n> transactions (default: 0, regtest: 1)
15-rpcport=<port>
16       Listen for JSON-RPC connections on <port> (default: 8332, testnet:
17       18332, regtest: 18443)

fanquake added this to the "Mergeable" column in a project

laanwj commented at 10:50 am on September 4, 2018: member

I think the reason that regtest was never mentioned in docs like this is that it is considered a developer/debug feature, not a user-facing one. Though, now that option help is no longer translated I don’t think it’s necessary to be so strict about that anymore here. utACK e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe

laanwj merged this on Sep 4, 2018

laanwj closed this on Sep 4, 2018

laanwj referenced this in commit 0f34dac67b on Sep 4, 2018

fanquake removed this from the "Mergeable" column in a project

deadalnix referenced this in commit 9754edd011 on Mar 17, 2020

ftrader referenced this in commit f62ac93aee on May 19, 2020

Munkybooty referenced this in commit 7457594c90 on Sep 8, 2021

MarcoFalke locked this on Sep 8, 2021

[doc] Add new regtest ports in man following #10825 ports reattributions #14013