fix walletcreatefundedpsbt deriv paths, add test #14055

1. 
   instagibbs commented at 9:04 PM on August 24, 2018: member

   Added the regression in #13968

2. fix walletcreatefundedpsbt deriv paths, add test 61fe653bd9
3. in test/functional/rpc_psbt.py:146 in 61fe653bd9

    142 | @@ -143,17 +143,19 @@ def run_test(self):
    143 |          # replaceable arg
    144 |          block_height = self.nodes[0].getblockcount()
    145 |          unspent = self.nodes[0].listunspent()[0]
    146 | -        psbtx_info = self.nodes[0].walletcreatefundedpsbt([{"txid":unspent["txid"], "vout":unspent["vout"]}], [{self.nodes[2].getnewaddress():unspent["amount"]+1}], block_height+2, {"replaceable":True})
    147 | +        psbtx_info = self.nodes[0].walletcreatefundedpsbt([{"txid":unspent["txid"], "vout":unspent["vout"]}], [{self.nodes[2].getnewaddress():unspent["amount"]+1}], block_height+2, {"replaceable":True}, False)
   

   ---

   ---

   

   Empact commented at 9:59 PM on August 24, 2018:

   nit: a comment for the boolean args would help with readability

4. 
   Empact commented at 10:00 PM on August 24, 2018: member

   utACK 61fe653

5. 
   achow101 commented at 10:50 PM on August 24, 2018: member

   utACK 61fe653bd919cb0533b2b9d6259bc86a4b2975c0

6. fanquake added the label Wallet on Aug 24, 2018
7. 
   instagibbs commented at 11:49 PM on August 26, 2018: member

   possible backport for 0.17, in case we're doing another RC? @fanquake

8. fanquake added the label Needs backport on Aug 27, 2018
9. laanwj added this to the milestone 0.17.0 on Aug 27, 2018
10. laanwj merged this on Aug 28, 2018
11. laanwj closed this on Aug 28, 2018

    ---

12. laanwj referenced this in commit 5de338ec72 on Aug 28, 2018
13. laanwj referenced this in commit 2307a6eb2b on Aug 28, 2018
14. laanwj removed the label Needs backport on Aug 28, 2018
15. uhliksk referenced this in commit 8defc585ac on Aug 29, 2018
16. DrahtBot locked this on Sep 8, 2021

Milestone
0.17.0