qa: Use assert not BOOST_CHECK_* from multithreaded tests #14069

1. 
   skeees commented at 1:43 PM on August 26, 2018: contributor

   Resolves thread sanitizer failure @MarcoFalke found in #14058

2. Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe 737670c036
3. MarcoFalke renamed this:
   Use assert not BOOST_CHECK_* from multithreaded tests
   qa: Use assert not BOOST_CHECK_* from multithreaded tests
   on Aug 26, 2018
4. MarcoFalke added the label Tests on Aug 26, 2018
5. MarcoFalke added this to the milestone 0.17.0 on Aug 26, 2018
6. MarcoFalke added the label Needs backport on Aug 26, 2018
7. MarcoFalke merged this on Aug 26, 2018
8. MarcoFalke closed this on Aug 26, 2018

   ---

9. MarcoFalke referenced this in commit 1117283543 on Aug 26, 2018
10. MarcoFalke referenced this in commit cf3d7f94c2 on Aug 27, 2018
11. MarcoFalke removed the label Needs backport on Aug 27, 2018
12. in src/test/scheduler_tests.cpp:141 in 737670c036

     137 | @@ -138,11 +138,11 @@ BOOST_AUTO_TEST_CASE(singlethreadedscheduler_ordered)
     138 |      // the callbacks should run in exactly the order in which they were enqueued
     139 |      for (int i = 0; i < 100; ++i) {
     140 |          queue1.AddToProcessQueue([i, &counter1]() {
     141 | -            BOOST_CHECK_EQUAL(i, counter1++);
     142 | +            assert(i == counter1++);
    

    ---

    ---

    

    practicalswift commented at 9:18 AM on August 28, 2018:

    Side effect in assertion: Fixed in #14088. Please review :-)

13. uhliksk referenced this in commit ad7dd7c54f on Aug 29, 2018
14. laanwj referenced this in commit 709a15b0a6 on Aug 31, 2018
15. HashUnlimited referenced this in commit fa3fe5a8c5 on Sep 14, 2018
16. PastaPastaPasta referenced this in commit 88a9682185 on Jun 27, 2021
17. PastaPastaPasta referenced this in commit 969de22347 on Jun 27, 2021
18. PastaPastaPasta referenced this in commit 2fc4775bfd on Jun 28, 2021
19. PastaPastaPasta referenced this in commit b5a3283124 on Jun 28, 2021
20. PastaPastaPasta referenced this in commit a6945f06dc on Jun 29, 2021
21. PastaPastaPasta referenced this in commit 5303574f90 on Jun 29, 2021
22. PastaPastaPasta referenced this in commit af66fc6ea3 on Jun 29, 2021
23. PastaPastaPasta referenced this in commit 60c722151f on Jun 29, 2021
24. PastaPastaPasta referenced this in commit 47361e1548 on Jun 29, 2021
25. PastaPastaPasta referenced this in commit 689230b978 on Jun 29, 2021
26. PastaPastaPasta referenced this in commit 29578a6148 on Jun 29, 2021
27. PastaPastaPasta referenced this in commit 658d86e0d4 on Jun 29, 2021
28. PastaPastaPasta referenced this in commit d9df41355c on Jun 29, 2021
29. PastaPastaPasta referenced this in commit 989e01887d on Jun 29, 2021
30. Munkybooty referenced this in commit f547446a20 on Jun 30, 2021
31. Munkybooty referenced this in commit 1ff26a39f1 on Jun 30, 2021
32. Munkybooty referenced this in commit d1d35d0796 on Jul 1, 2021
33. PastaPastaPasta referenced this in commit ee68324db5 on Jul 1, 2021
34. PastaPastaPasta referenced this in commit cd5a39c8af on Jul 1, 2021
35. DrahtBot locked this on Sep 8, 2021

Contributors

skeeespracticalswift

Milestone
0.17.0