Cleans https://github.com/bitcoin/bitcoin/pull/13961/files#r213135952.
Remove unnecessary G_TRANSLATION_FUN nullptr assignment #14087
pull promag wants to merge 1 commits into bitcoin:master from promag:2018-08-clean-13961 changing 6 files +6 −6-
promag commented at 10:33 PM on August 27, 2018: member
-
Remove unnecessary G_TRANSLATION_FUN nullptr assignment 508b65c74b
-
practicalswift commented at 10:41 PM on August 27, 2018: contributor
utACK 508b65c74b9515a62e8ee55bc4c28cb3684b0263
- fanquake added the label Refactoring on Aug 27, 2018
-
ken2812221 commented at 12:52 AM on August 28, 2018: contributor
Does this improve something?
-
promag commented at 12:54 AM on August 28, 2018: member
No.
-
Empact commented at 1:00 AM on August 28, 2018: member
utACK 508b65c less code is bettter code
-
laanwj commented at 10:46 AM on August 28, 2018: member
TBH I like the explicit construction more, this change seems completely unnecessary
- laanwj closed this on Aug 28, 2018
-
- laanwj reopened this on Aug 28, 2018
-
laanwj commented at 1:51 PM on August 28, 2018: member
oh I see, it's not a pointer, ok fine, yes then it's not sensible to assign nullptr
was just getting a bit annoyed with getting a "clean up" PR after every PR, sorry
-
MarcoFalke commented at 2:07 PM on August 28, 2018: member
Tend to agree with @laanwj. According to https://en.cppreference.com/w/cpp/utility/functional/function/function both variations "1-2) Creates an empty function." If one variant is preferable, it should be mentioned in the developer notes.
-
promag commented at 6:35 PM on August 28, 2018: member
I prefer 1) but I don't care that much.
- promag closed this on Aug 28, 2018
- promag deleted the branch on Sep 2, 2018
- MarcoFalke locked this on Sep 8, 2021
