Dry run bench_bitcoin (-evals=1 -scaling=0: <1 second running time) as part make check to allow for quick identification of assertion/sanitizer failures or crashes in benchmarking code.
This is already tested in Travis but it is nice to have it locally too. The cost is near zero.
166@@ -167,6 +167,8 @@ check-local: $(BITCOIN_TESTS:.cpp=.cpp.test)
167 $(PYTHON) $(top_builddir)/test/util/bitcoin-util-test.py
168 @echo "Running test/util/rpcauth-test.py..."
169 $(PYTHON) $(top_builddir)/test/util/rpcauth-test.py
170+ @echo "Running bench/bench_bitcoin -evals=1 -scaling=0..."
171+ $(top_builddir)/src/bench/bench_bitcoin -evals=1 -scaling=0 2> >(grep -vE "^WARNING: ") > /dev/null
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Tested by merging dfef0df and then applying the changes from #14011 (so that make check actually runs on macOS).
Got the bench output:
0OK
1Running bench/bench_bitcoin -evals=1 -scaling=0...
2bench/bench_bitcoin -evals=1 -scaling=0 > /dev/null
3.....
Added an assert(0) to AssembleBlock to check that a failure is caught.
0OK
1Running bench/bench_bitcoin -evals=1 -scaling=0...
2bench/bench_bitcoin -evals=1 -scaling=0 > /dev/null
3Assertion failed: (0), function AssembleBlock, file bench/block_assemble.cpp, line 57.
4/bin/sh: line 1: 60728 Abort trap: 6 bench/bench_bitcoin -evals=1 -scaling=0 > /dev/null
5make[3]: *** [check-local] Error 134
6make[2]: *** [check-am] Error 2
7make[1]: *** [check-recursive] Error 1
8make: *** [check-recursive] Error 1
Probably worth getting @theuni to glance over the test.include changes pre-merge.