lint: Make sure we read the command line inputs using utf-8 decoding in python #14128

1. 
   ken2812221 commented at 10:45 pm on September 1, 2018: contributor

   Make sure we read the command line inputs using utf-8 decoding in python

   occurred from travis cron job:

   contrib/verify-commits/verify-commits.py should run with utf-8, otherwise it would raise UnicodeDecodeError UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 744: ordinal not in range(128)

2. laanwj added the label Tests on Sep 1, 2018
3. 
   laanwj commented at 10:54 pm on September 1, 2018: member

   I think it would be better to fix the .py script to always read as utf-8, this should be independent of the system locale

   (we’ve done this for the other ones) apparently this was the intent here too:

   0    revsig_allowed = open(dirname + "/allow-revsig-commits", "r", encoding="utf-8").read().splitlines()
   1    unclean_merge_allowed = open(dirname + "/allow-unclean-merge-commits", "r", encoding="utf-8").read().splitlines()
   2    incorrect_sha512_allowed = open(dirname + "/allow-incorrect-sha512-commits", "r", encoding="utf-8").read().splitlines()
   

   Do you know where it fails?

4. ken2812221 force-pushed on Sep 1, 2018
5. ken2812221 force-pushed on Sep 1, 2018
6. 
   ken2812221 commented at 11:37 pm on September 1, 2018: contributor

   Do you know where it fails?

   It is check_output

7. 
   DrahtBot commented at 11:39 pm on September 1, 2018: member
8. ken2812221 force-pushed on Sep 1, 2018
9. ken2812221 force-pushed on Sep 1, 2018
10. ken2812221 force-pushed on Sep 2, 2018
11. 
    fanquake commented at 5:59 am on September 2, 2018: member

    concept ACK @ken2812221 Can you update the commit message, PR title and description to match the current changes.
12. lint: Make sure we read the command line inputs using utf-8 decoding in python 5d62dcf9cf
13. ken2812221 force-pushed on Sep 2, 2018
14. ken2812221 renamed this:
    travis: Fix cron job fail
    lint: Make sure we read the command line inputs using utf-8 decoding in python
    on Sep 2, 2018
15. 
    ken2812221 commented at 1:44 pm on September 2, 2018: contributor

    @fanquake Thanks, updated
16. 
    practicalswift commented at 7:18 pm on September 2, 2018: contributor

    utACK 5d62dcf9cfb5c0b2511c10667ed47ec3b3610d72

    Nice linter improvement!

17. 
    fanquake commented at 10:42 pm on September 2, 2018: member

    @ken2812221 Thanks, utACK 5d62dcf.
18. 
    laanwj commented at 10:34 am on September 4, 2018: member

    thanks! utACK 5d62dcf9cfb5c0b2511c10667ed47ec3b3610d72
19. laanwj merged this on Sep 4, 2018
20. laanwj closed this on Sep 4, 2018

    ---

21. laanwj referenced this in commit fa616275b2 on Sep 4, 2018
22. ken2812221 deleted the branch on Sep 4, 2018
23. deadalnix referenced this in commit 4528a9a1bf on May 6, 2020
24. Munkybooty referenced this in commit 123cb6e114 on Jul 1, 2021
25. Munkybooty referenced this in commit 77ec56e7f3 on Jul 2, 2021
26. Munkybooty referenced this in commit 4909506e6a on Jul 3, 2021
27. UdjinM6 referenced this in commit 1be23d035f on Jul 3, 2021
28. Munkybooty referenced this in commit 524d5959cf on Jul 3, 2021
29. UdjinM6 referenced this in commit 041cd214d3 on Jul 3, 2021
30. Munkybooty referenced this in commit 7214b034eb on Jul 7, 2021
31. Munkybooty referenced this in commit 9f003b390a on Jul 8, 2021
32. MarcoFalke locked this on Sep 8, 2021

Contributors
ken2812221 laanwj DrahtBot fanquake practicalswift

Labels
Tests