Docs: Add disable-wallet section to OSX build instructions, update line in Unix instructions #14153

pull bitstein wants to merge 2 commits into bitcoin:master from bitstein:build-osx-disable-wallet changing 2 files +12 −3

bitstein commented at 6:59 PM on September 5, 2018: contributor

The disable-wallet section was mentioned in the Berkeley DB section of the OSX build instructions, but the section did not actually exist. This PR ports the section from the Unix build instructions.
Docs: Add disable-wallet section to OSX build instructions a6f16f1b1a
Remove reference to deprecated RPC call in build instructions e351a16a2a
in doc/build-osx.md:77 in a6f16f1b1a outdated
```
  72 | +    ./configure --disable-wallet
  73 | +
  74 | +In this case there is no dependency on Berkeley DB 4.8.
  75 | +
  76 | +Mining is also possible in disable-wallet mode, but only using the `getblocktemplate` RPC
  77 | +call not `getwork`.
```
MarcoFalke commented at 7:04 PM on September 5, 2018:

I doubt that such an option even exists: I get unknown command: getwork
bitstein commented at 7:10 PM on September 5, 2018:

Should I add a commit to update that line in both the Unix and OSX build instructions to the following?

Mining is also possible in disable-wallet mode using the `getblocktemplate` RPC call.
MarcoFalke commented at 7:16 PM on September 5, 2018:

Right, could make sense to remove it in build-unix.md as well.

Though, shouldn't the configure options be independent of operating system? So maybe a doc shared across all os that describes the configure options could make sense. (no strong opinion on this)

bitstein commented at 7:20 PM on September 5, 2018:

I noticed every operating system has a very difficult structure and format for its build instructions. It would be nice to see that more standardized. In this instance, I had been specifically building on OSX, which made me notice the missing section. I'll make that commit and update the PR title for now.
bitstein renamed this:
~~Docs: Add disable-wallet section to OSX build instructions~~
Docs: Add disable-wallet section to OSX build instructions, update line in Unix instructions
on Sep 5, 2018
fanquake added the label Docs on Sep 5, 2018
Sjors commented at 4:03 PM on September 6, 2018: member

utACK a6f16f1, although longer term I prefer @MarcoFalke's:

maybe a doc shared across all os that describes the configure options could make sense.

getwork was indeed removed in 0.10
MarcoFalke commented at 4:42 PM on September 6, 2018: member

utACK e351a16a2a837091d6bb51c0ac9b4c52a036f393
fanquake commented at 10:30 AM on September 7, 2018: member

utACK e351a16
MarcoFalke merged this on Sep 7, 2018
MarcoFalke closed this on Sep 7, 2018
MarcoFalke referenced this in commit b8cf492e85 on Sep 7, 2018
Munkybooty referenced this in commit 06bc43a1f8 on Jul 1, 2021
Munkybooty referenced this in commit dad8d7da93 on Jul 2, 2021
Munkybooty referenced this in commit 800fbf88f0 on Jul 3, 2021
UdjinM6 referenced this in commit 4174647bb3 on Jul 3, 2021
Munkybooty referenced this in commit 0628388bc5 on Jul 3, 2021
UdjinM6 referenced this in commit 010f9583fd on Jul 3, 2021
Munkybooty referenced this in commit e5d2ff5d45 on Jul 7, 2021
Munkybooty referenced this in commit 9cda3a7c43 on Jul 8, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels