Currently the functional tests require the wallet module to be compiled into the Bitcoin Core executable. For example the premine (or datadir cache) to speed up tests when run in parallel would mine a bunch of blocks and store the private keys to sign the coinbase tx outputs in a wallet. There is no need to have the overhead of the whole wallet module by using keys that are deterministic for all runs.
Note that this change most likely requires the ./test/cache/ to be cleared.
246@@ -247,6 +247,14 @@ def setup_nodes(self):
247 self.add_nodes(self.num_nodes, extra_args)
248 self.start_nodes()
249
250+ def import_deterministic_coinbase_privkeys(self):
251+ for n in self.nodes:
252+ wallet_enabled = 'Wallet' in [line[3:-3] for line in n.help().splitlines() if line.startswith('==')]
This seems a little brittle (based on the exact text output of the help text).
Calling getwalletinfo and catching the returned error is an alternative way to do this.
246@@ -247,6 +247,14 @@ def setup_nodes(self):
247 self.add_nodes(self.num_nodes, extra_args)
248 self.start_nodes()
249
250+ def import_deterministic_coinbase_privkeys(self):
import_deterministic_coinbase_privkeys() to setup_nodes()? Would that reduce the number of tests that you need to change in this commit?
run_test, unless self.setup_clean_chain is set.
Concept ACK.
A couple of suggested changes inline. There are also a bunch of unrelated style changes in your commit. Can you remove those or split them into their own commit?
96@@ -97,6 +97,22 @@ def __init__(self, i, datadir, *, rpchost, timewait, bitcoind, bitcoin_cli, mock
97
98 self.p2ps = []
99
100+ def get_deterministic_priv_key(self):
101+ """Return a deterministic priv key in base58, that only depends on the node's index"""
102+ PRIV_KEYS = [
103+ # adress , privkey
codespell:
0test/functional/test_framework/test_node.py:103: adress ==> address
17@@ -18,6 +18,11 @@ class ReceivedByTest(BitcoinTestFramework):
18 def set_test_params(self):
19 self.num_nodes = 2
20
21+ def import_deterministic_coinbase_privkeys(self):
22+ assert_equal(0, len(self.nodes[1].listreceivedbyaddress(minconf=0, include_empty=True, include_watchonly=True)))
23+ super().import_deterministic_coinbase_privkeys()
24+ self.num_cb_reward_addresses = len(self.nodes[1].listreceivedbyaddress(minconf=0, include_empty=True, include_watchonly=True))
cb_reward with just coinbase to be more consistent.
33- # key = key_label.split(" ")[0]
34- keytype = key_label.split(" ")[2]
35- if len(comment) > 1:
36- addr_keypath = comment.split(" addr=")[1]
37- addr = addr_keypath.split(" ")[0]
38+ key_date_label, comment = line.split("#")
167@@ -168,6 +168,11 @@ def transact_and_mine(self, numblocks, mining_node):
168 newmem.append(utx)
169 self.memutxo = newmem
170
171+ def import_deterministic_coinbase_privkeys(self):
172+ self.start_nodes()
import_deterministic_coinbase_privkeys be smart enough to know whether nodes are running or not with node.is_node_stopped (or other state)? It seems unfortunate that an individual test would need to override the import_deterministic_coinbase_privkeys method to get such basic functionality.
39@@ -40,6 +40,13 @@ def set_test_params(self):
40 def setup_nodes(self):
41 skip_if_no_py3_zmq()
42 skip_if_no_bitcoind_zmq(self)
43+
44+ # Import keys
import_deterministic_coinbase_privkeys call work in this test? There should be a comment here to explain why this override is needed if the default behavior can’t be fixed.
115@@ -116,10 +116,19 @@ def setup_network(self):
116 extra_args[i] += ["-prune=1"]
117
118 self.add_nodes(self.num_nodes, extra_args=extra_args)
119+
120+ # Import keys