Qt: Fix restoration of minimized to tray window #14222

1. 
   hebasto commented at 1:17 am on September 15, 2018: member

   Fix UX bug on Windows. Steps to reproduce (tested on Windows 10):

   1. In Options->Window enable “Minimize to the tray instead of the taskbar”.
   2. Minimize the main window.
   3. Select Show/Hide on the tray icon menu (or just click on the tray icon).

   The normal size window is expected.

   Actually the main window is restored minimized to the taskbar.

   Rationale: minimizing the window with fMinimizeToTray==true actually do both showMinimized() and hide(). During restoration isMinimized() should be checked first. Otherwise, the restored window will be minimized.

   The logic is broken both on Windows and Linux, but on my Linux (Mint 19 + Cinnamon 3.8.9) the window manager renders the main window as if all is correct. Nevertheless, other Linux systems may be affected by this bug.

   Ref:

   • #8225
   • #11859
2. Fix restoration of minimized to tray window

   Minimizing the window with fMinimizeToTray=true actually do both
   showMinimized() and hide(). During restoration isMinimized() should be
   checked first. Otherwise, the restored window will be minimized.

   f03c5c3025
3. fanquake added the label GUI on Sep 15, 2018
4. 
   fanquake commented at 2:10 am on September 15, 2018: member

   @hebasto Can you have a look at #14123, as it might fix the issue you’re seeing.
5. 
   DrahtBot commented at 4:06 am on September 15, 2018: member

   • #14594 (qt: Fix bug #14591 by hebasto)
   • #14123 (gui: Add GUIUtil::bringToFront by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   jonasschnelli commented at 8:31 am on September 27, 2018: contributor

   Tested ACK f03c5c30254349314789c0c756d6ba11914d004c

   This successfully solves the “two step” show with the tray icon. Tested on all Ubuntu/macOS/Win.

7. 
   MarcoFalke commented at 4:20 pm on September 27, 2018: member

   Is this for backport?
8. 
   jonasschnelli commented at 6:20 pm on September 27, 2018: contributor

   Not sure this is worth back-porting… All UI-glitch-fixes have the risk to act differently in back ported versions. I would recommend to not back port it (if its not a clear bug that has been fixed).
9. 
   DrahtBot commented at 10:29 am on September 28, 2018: member

   Coverage	Change (pull 14222)	Reference (master)
   Lines	+0.0044 %	87.0361 %
   Functions	+0.0154 %	84.1130 %
   Branches	-0.0190 %	51.5451 %

10. 
    hebasto commented at 2:28 pm on October 12, 2018: member

    @Sjors Do you mind reviewing this PR?
11. 
    Sjors commented at 6:50 am on October 13, 2018: member

    I can’t find the “Minimize to the tray instead of the taskbar” option on macOS 10.14 with QT 5.11.2.
12. 
    hebasto commented at 10:51 am on October 13, 2018: member

    @Sjors https://github.com/bitcoin/bitcoin/blob/f78558f1e39198779bdb17e2b0e256fb99ad4b28/src/qt/optionsdialog.cpp#L72-L76
13. 
    Sjors commented at 3:05 am on October 14, 2018: member

    Ok, this seems to have no effect on macOS, so works for me. @promag does this get in the way of what you’re trying to achieve in #14123? That PR fixes #13829, this PR doesn’t.
14. 
    fanquake commented at 11:20 pm on October 28, 2018: member

    Closing in favour of #14123, as that has more recent review, and according to this comment they should be fixing the same issue.
15. fanquake closed this on Oct 28, 2018

    ---

16. hebasto deleted the branch on Nov 8, 2018
17. MarcoFalke locked this on Sep 8, 2021

Contributors
hebasto fanquake DrahtBot jonasschnelli MarcoFalke Sjors

Labels
GUI