Build: during 'make clean', remove some files that are currently missed. #14253

pull murrayn wants to merge 1 commits into bitcoin:master from murrayn:makedistclean changing 2 files +2 −2

murrayn commented at 9:24 AM on September 18, 2018: contributor

make clean currently leaves behind some cache and test log files that should be removed.
fanquake added the label Build system on Sep 18, 2018
fanquake requested review from theuni on Sep 18, 2018
in src/Makefile.am:550 in 63fc71e994 outdated
```
 546 | @@ -547,6 +547,7 @@ CLEANFILES += wallet/*.gcda wallet/*.gcno
 547 |  CLEANFILES += wallet/test/*.gcda wallet/test/*.gcno
 548 |  CLEANFILES += zmq/*.gcda zmq/*.gcno
 549 |  CLEANFILES += obj/build.h
 550 | +CLEANFILES += test/*.cpp.log wallet/test/*.cpp.log
```
theuni commented at 8:13 PM on September 26, 2018:

To avoid adding another nasty wildcard, I think this one can be $(BITCOIN_TESTS:.cpp=.cpp.log) .

Also, please append it to CLEAN_BITCOIN_TEST in Makefile.test.include instead, to keep the test stuff in one place.
theuni commented at 8:14 PM on September 26, 2018: member

utACK other than the requested change.
murrayn commented at 8:12 AM on September 27, 2018: contributor

@theuni thanks for the feedback. I've made the change you suggested.
DrahtBot commented at 7:29 PM on September 27, 2018: member

No more conflicts as of last run.
theuni commented at 11:04 PM on September 27, 2018: member

utACK the changes, thank you.

Please squash them down to a single commit though.
DrahtBot commented at 7:19 AM on September 28, 2018: member



Coverage Change (pull 14253) Reference (master)

Lines +0.0132 % 87.0361 %

Functions +0.0772 % 84.1130 %

Branches +0.0161 % 51.5451 %
Include some files currently missed by 'make distclean'. 3f5ac27205
murrayn force-pushed on Oct 1, 2018
fanquake commented at 6:44 AM on October 8, 2018: member

tACK 3f5ac27
theuni commented at 6:55 AM on October 8, 2018: member

utACK 3f5ac2720520e9bce064ae6d28ba5f0488b2087a
MarcoFalke referenced this in commit da32bd80bf on Oct 8, 2018
MarcoFalke merged this on Oct 8, 2018
MarcoFalke closed this on Oct 8, 2018

Coverage	Change (pull 14253)	Reference (master)
Lines	+0.0132 %	87.0361 %
Functions	+0.0772 %	84.1130 %
Branches	+0.0161 %	51.5451 %

in Makefile.am:297 in 3f5ac27205

 293 | @@ -294,5 +294,5 @@ clean-docs:
 294 |  
 295 |  clean-local: clean-docs
 296 |  	rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
 297 | -	rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache
 298 | +	rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__

MarcoFalke commented at 7:16 AM on October 9, 2018:

This also deletes src/test/scriptnum10.h

PastaPastaPasta referenced this in commit 9d0fb5c295 on Jul 17, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels