refactor: Lift prevector default vals to the member declaration #14266

1. 
   Empact commented at 7:22 AM on September 19, 2018: member

   I overlooked this possibility in #14028

2. Lift prevector default vals to the member declaration d2eee87928
3. fanquake added the label Refactoring on Sep 19, 2018
4. 
   MarcoFalke commented at 12:28 PM on September 19, 2018: member

   Are there any performance or other implications?

5. 
   Empact commented at 1:50 PM on September 19, 2018: member

   Main argument for this is that it is protective against another constructor being added but neglecting to initialize these vars properly.

6. 
   promag commented at 8:41 PM on September 19, 2018: member

   utACK d2eee87, change looks good because members are always initialized.

7. 
   l2a5b1 commented at 3:18 PM on September 22, 2018: contributor

   utACK d2eee87 nice one.

   nit: perhaps initialize _union and _size with an empty initializer list {}: _size {}; _union {};.

8. 
   ken2812221 commented at 9:39 AM on September 27, 2018: contributor

   utACK d2eee87928781ab3082d4279aa6f19641a45e801

9. 
   laanwj commented at 2:49 PM on December 13, 2018: member

   @sipa can you have a look at this please

10. MarcoFalke deleted a comment on Dec 13, 2018
11. 
    sipa commented at 5:49 PM on December 13, 2018: member

    @MarcoFalke I expect that this will have no effect on performance (the default initializers being invoked instead of delegating to the default constructor should do the exact same thing).

    utACK

12. 
    practicalswift commented at 2:39 PM on December 20, 2018: contributor

    utACK d2eee87928781ab3082d4279aa6f19641a45e801

13. 
    DrahtBot commented at 9:33 AM on January 12, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

14. 
    practicalswift commented at 1:38 PM on April 29, 2019: contributor

    Current version has four utACK:s -- ready for merge? :-)

15. 
    Empact commented at 7:47 AM on April 30, 2019: member

    Five ;)

16. 
    scravy commented at 1:31 PM on April 30, 2019: contributor

    utACK d2eee87928781ab3082d4279aa6f19641a45e801

17. MarcoFalke renamed this:
    Lift prevector default vals to the member declaration
    refactor: Lift prevector default vals to the member declaration
    on Apr 30, 2019
18. MarcoFalke added this to the milestone 0.19.0 on Apr 30, 2019
19. MarcoFalke merged this on May 6, 2019
20. MarcoFalke closed this on May 6, 2019

    ---

21. MarcoFalke referenced this in commit 3632143ebb on May 6, 2019
22. sidhujag referenced this in commit e97c1bc114 on May 7, 2019
23. random-zebra referenced this in commit e0239f801d on May 22, 2020
24. PastaPastaPasta referenced this in commit 3325df2cc1 on Jun 27, 2021
25. PastaPastaPasta referenced this in commit cdbf7957d2 on Jun 28, 2021
26. PastaPastaPasta referenced this in commit 612b7e8fab on Jun 29, 2021
27. PastaPastaPasta referenced this in commit 90f2117558 on Jul 1, 2021
28. PastaPastaPasta referenced this in commit 7b1d8c5e53 on Jul 1, 2021
29. PastaPastaPasta referenced this in commit bb27dde3cc on Jul 8, 2021
30. PastaPastaPasta referenced this in commit 698ca44c98 on Jul 10, 2021
31. MarcoFalke locked this on Dec 16, 2021

Contributors

EmpactMarcoFalkepromagl2a5b1ken2812221laanwjsipapracticalswiftDrahtBotscravy

Milestone
0.19.0